1013475 - make inIDeepTreeWalker stop depending on nsIDOMTreeWalker

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nathan Froyd [:froydnj]]

nsIDOMTreeWalker isn't scriptable, and inIDeepTreeWalker is.  We shouldn't have such interfaces in our tree.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: give inIDeepTreeWalker all of nsIDOMTreeWalker's methods/attributes, rather than inheriting them

Cut-and-paste programming at its finest.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8425650 [details] [diff] [review]
give inIDeepTreeWalker all of nsIDOMTreeWalker's methods/attributes, rather than inheriting them

r=me assuming nothing on the C++ side tries to use this sucker as an nsIDOMTreeWalker.

Comment 3

[Nathan Froyd [:froydnj]]

Try run said no C++ use:

https://tbpl.mozilla.org/?tree=Try&rev=ae069f151f82

Then again, it's only used in this one testcase.  Maybe we should just ditch the interface entirely?  Do addons use it?

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea0448aacaa3

Comment 4

[Boris Zbarsky [:bzbarsky]]

Hrm.  The DOM inspector addon certainly does, no?

https://mxr.mozilla.org/addons/search?string=deep-tree-walker says so do another 10 addons or so.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea0448aacaa3