1013478 - Use GCC 4.8 by default if available

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Right now we default to GCC 4.7, but NDK r9 and above don't have 4.7 and have 4.8 instead. So we should default to 4.8 if available. GCC below 4.7 won't work because of recent changes [1].

[1] https://mail.mozilla.org/pipermail/mobile-firefox-dev/2014-May/000654.html
    https://mail.mozilla.org/pipermail/mobile-firefox-dev/2014-May/000655.html

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use GCC 4.8 on Android if available (v1)

This adds 4.8 to the list of compilers. It also removes unsupported ones so the build fails earlier rather than later.

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8425738 [details] [diff] [review]
Use GCC 4.8 on Android if available (v1)

Review of attachment 8425738 [details] [diff] [review]:
-----------------------------------------------------------------

wfm.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Jim Chen [:jchen :nchen] from comment #0)
> GCC below 4.7 won't work because of recent changes [1].

Arguably, those should be fixed.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8425738 [details] [diff] [review]
Use GCC 4.8 on Android if available (v1)

Review of attachment 8425738 [details] [diff] [review]:
-----------------------------------------------------------------

It's fine to use 4.8 if 4.7 is not there, but i don't think we should switch to 4.8 if 4.7 is available.

Comment 5

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #3)
> (In reply to Jim Chen [:jchen :nchen] from comment #0)
> > GCC below 4.7 won't work because of recent changes [1].
> 
> Arguably, those should be fixed.

And it's a simple fix: bug 1013646.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1013478 - Use GCC 4.8 on Android if available;

I think it still makes sense to default to 4.8 if available. I verified that NDK r9x only have 4.8 and not 4.7, i.e. there's no NDK that has both 4.8 and 4.7.

Right now we default to 4.7 for exactly two NDK revs,
> r8e:    GCC 4.6
r8d, r8e: GCC 4.7
r8b, r8c: GCC 4.6
< r8b:    GCC 4.4.3

But I think it makes better sense if we default to 4.8 for newer revs,
> r8e:    GCC 4.8
r8d, r8e: GCC 4.7
r8b, r8c: GCC 4.6
< r8b:    GCC 4.4.3

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=4ed872d769fd

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86de442c14a4

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/86de442c14a4