1013532 - Prep casting code to enable casting and Roku on Nightly

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: enable-casting v0.1

This patch does a few things:
* Starts looking for "FirefoxNightly" or "Firefox" as the Roku app name on Nightly/Aurora or Beta/Release respectively.
* Stops passing the aApp name around since all users are providing the name internally
* Enables casting on Nightly/Aurora

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I am blocked on releasing the Roku app for this patch. Let me know if you want me to get a different reviewer.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8425715 [details] [diff] [review]
enable-casting v0.1

Review of attachment 8425715 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/modules/RokuApp.jsm
@@ +20,5 @@
>  /* RokuApp is a wrapper for interacting with a Roku channel.
>   * The basic interactions all use a REST API.
>   * spec: http://sdkdocs.roku.com/display/sdkdoc/External+Control+Guide
>   */
>  function RokuApp(service, app) {

No need for this argument.

Comment 3

[Wesley Johnston (:wesj)]

I wonder if we'll need this back if we want to launch the YouTube app for instance... I'm not sure how we'll do that tbh though.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Wesley Johnston (:wesj) from comment #2)

> >  function RokuApp(service, app) {
> 
> No need for this argument.

Oops. I'll remove.

(In reply to Wesley Johnston (:wesj) from comment #3)
> I wonder if we'll need this back if we want to launch the YouTube app for
> instance... I'm not sure how we'll do that tbh though.

I'd rather make a YouTube subclass. I think. We'll cross that bridge later.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/910584ed1bba

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/910584ed1bba