1013623 - Leak nsHttpConnectionMgr::nsConnectionHandle with pipelining enabled

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Set
     user_pref("network.http.pipelining", true);
2. Run Firefox with XPCOM_MEM_LEAK_LOG=2
3. Load the testcase
4. Quit Firefox

Result: trace-refcnt reports a leak of nsHttpConnectionMgr::nsConnectionHandle

Based on when I started seeing this, I'm guessing it's a regression from bug 378637.

Comment 1

[Patrick McManus [:mcmanus]]

jesse thanks for finding this.

the issue is a latent bug made more obvious by 378637. I tried to fix it up in patch 15 of that bug, but my patch was wrong because I treated mConnection as a smart pointer when it was just a "type *".

Comment 2

[Patrick McManus [:mcmanus]]

Attachment: make nsHttpPipeline.mConnection a smart pointer

Comment 3

[Patrick McManus [:mcmanus]]

 https://tbpl.mozilla.org/?tree=Try&rev=952fd8fdd483

Comment 4

[Patrick McManus [:mcmanus]]

   https://hg.mozilla.org/integration/mozilla-inbound/rev/22e8c11b2108

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/22e8c11b2108