Closed Bug 1013670 Opened 5 years ago Closed 5 years ago

Remove all traces of leaktest.py.in

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: ted, Assigned: njn)

References

Details

(Whiteboard: [mentor=ted][good first bug])

Attachments

(1 file)

We stopped running this test in bug 617441. We should remove it from the tree.
Whiteboard: [mentor=ted] → [mentor=ted][good first bug]
Things I'm unsure about:

- Do we still need the following lines in build/Makefile.in?

> TARGET_DEPTH = ..
> include $(srcdir)/automation-build.mk

- Do we still need bloatcycle.html? The only remaining mention of it is in
  comments in tools/rb/bloatdiff.pl.
Attachment #8425965 - Flags: review?(ted)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment on attachment 8425965 [details] [diff] [review]
Remove all traces of leaktest.py.in

Review of attachment 8425965 [details] [diff] [review]:
-----------------------------------------------------------------

You can remove bloatcycle.html as well, this is the only consumer. (I bet nobody is actually using bloatdiff.pl either, but I don't care that much.)

::: build/Makefile.in
@@ -70,2 @@
>  TARGET_DEPTH = ..
>  include $(srcdir)/automation-build.mk

This is only used for leaktest.py in this Makefile (although that's certainly not clear from inspection), so you can remove it (along with the reference to automationutils.pyc at the bottom).
Attachment #8425965 - Flags: review?(ted) → review+
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> (along with the reference to automationutils.pyc at the bottom).

That one is still necessary.
With some help from glandium and the try server, I determined that the TARGET_DEPTH and automation-build.mk lines were necessary, and the |libs::| target still needed to depend on automation.py.

https://hg.mozilla.org/integration/mozilla-inbound/rev/aac960513e7a
https://hg.mozilla.org/mozilla-central/rev/aac960513e7a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.