1013670 - Remove all traces of leaktest.py.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

We stopped running this test in bug 617441. We should remove it from the tree.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove all traces of leaktest.py.in

Things I'm unsure about:

- Do we still need the following lines in build/Makefile.in?

> TARGET_DEPTH = ..
> include $(srcdir)/automation-build.mk

- Do we still need bloatcycle.html? The only remaining mention of it is in
  comments in tools/rb/bloatdiff.pl.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8425965 [details] [diff] [review]
Remove all traces of leaktest.py.in

Review of attachment 8425965 [details] [diff] [review]:
-----------------------------------------------------------------

You can remove bloatcycle.html as well, this is the only consumer. (I bet nobody is actually using bloatdiff.pl either, but I don't care that much.)

::: build/Makefile.in
@@ -70,2 @@
>  TARGET_DEPTH = ..
>  include $(srcdir)/automation-build.mk

This is only used for leaktest.py in this Makefile (although that's certainly not clear from inspection), so you can remove it (along with the reference to automationutils.pyc at the bottom).

Comment 3

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> (along with the reference to automationutils.pyc at the bottom).

That one is still necessary.

Comment 4

[Nicholas Nethercote [inactive]]

With some help from glandium and the try server, I determined that the TARGET_DEPTH and automation-build.mk lines were necessary, and the |libs::| target still needed to depend on automation.py.

https://hg.mozilla.org/integration/mozilla-inbound/rev/aac960513e7a

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aac960513e7a