1013676 - [B2G][Mobile] MTV artist search modal closed by soft keyboard opening and global resize event listener

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[pete siphantong [:Petes]]

Description:
The search button on MTV artist page does not function on the Firefox mobile


Repro Steps:
1. Go to http://m.mtv.com/
2. Tap on Artist 
3. Tap either search button 


Actual:
The search button on MTV artist page does not function on the Firefox mobile


Expected:
The user should be able to type in the search field 


The issue occurs on the following devices:

1.4F Environmental Variables:
Device: Flame 1.4F
BuildID: 20140519000201
Gaia: defd0650fb9d30c6515d50a89e72d8fb74ce7e62
Gecko: d95594048b36
Version: 30.0
Firmware Version: v10F-3

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140516000201
Gaia: 32fca83da31b9a0f9a5a88f96c913a25accdc14b
Gecko: a1e455367fa6
Version: 30.0
Firmware Version: v1.2-device.cfg

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140514024003
Gaia: 96e3fa769a436a2182e6d54088fb41386eb2b5b5
Gecko: 685cf1d0dedb
Version: 28.0
Firmware Version: v1.2-device.cfg
 

Repro frequency: 100%
See attached: video

Comment 1

[pete siphantong [:Petes]]

https://www.youtube.com/watch?v=jS4VdY-Jjno

Comment 2

[Mike Taylor [:miketaylr]]

Same thing reproduces with Firefox for Android.

Comment 3

[Mike Taylor [:miketaylr]]

Apparently the /artists link takes you to a responsive site, http://www.mtv.com/artists/?hp=en-Artists. Digging into ArtistPlatform.searchModal now:

<a href="#" onclick="ArtistPlatform.searchModal.reportAPSearchLaunchedByClick();">search</a>

Comment 4

[Mike Taylor [:miketaylr]]

In bundle-ap-lib-head_head.js

ArtistPlatform.searchModal.initSearchTriggers = function initSearchTriggers() {
  function bindToResize(){
    if(typeof window.onorientationchange == 'undefined'){
      //hide search on desktop
      $(window).bind('resize', ArtistPlatform.searchModal.clickhide );
      }
  }
  bindToResize();
...

window.resize is triggered when the soft-keyboard pops up, and since we don't support window.orientation (or window.onorientationchange), this resize event immediately closes the modal. Given the comment, it seems they're using the lack of window.onorientationchange to detect Desktop vs. Mobile.

I'm not really sure why you'd want to close the search modal on resize... perhaps they're working around some other issue? A not-very-satisfying recommended fix for this issue would be to delete this resize handler... or add some other condition to check screen sizes.

Comment 5

[Mike Taylor [:miketaylr]]

This is working now.