1013708 - in-content preferences advanced pane: remove text shadow from sub categories

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Sören Hentzschel]

Attachment: preferences-advanced.png

Please remove the text shadow of the in-content preferences advanced panel sub category labels, it difficult to read, see screenshot.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: horizontalTabs.patch

This patch uses the styles from Project Chameleon.

I had to change the pane background-color to white like Chameleon to let the tabs look better. And this needed on Windows to remove the caption background color. On OS X I removed also the line below the captions.

On Project Chameleon where was no spec for the dimensions and I choosed the best fitting ones.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: horizontalTabs.patch

Found on Project Chameleon under Navigation - Horizontal inContent Navigation a different tabs background color for not active tabs. And also a updated transition.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8430815 [details] [diff] [review]
horizontalTabs.patch

Review of attachment 8430815 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/incontentprefs/preferences.css
@@ +102,5 @@
>  }
>  
> +tab:hover {
> +  background-color: #ebebeb;
> +}  

nit: trailing whitespace

@@ +108,3 @@
>  tab[selected] {
> +  background-color: #ebebeb;
> +  box-shadow: inset 0 -4px 0 0 #ff9500;

The linux theme adds a few rules for tab[selected] which need to be overriden.

Can you add a rule to the browser/themes/linux/incontentprefs/preferences.css for
tab[selected] {
  /* Override the margin-bottom for tab[selected]
     from toolkit/themes/linux/global/tabbox.css */
  margin-bottom: 0;
  border-bottom-left-radius: 0;
  border-bottom-right-radius: 0;
}

Comment 4

[Richard Marti (:Paenglab)]

Attachment: horizontalTabs.patch

Fixed comments and updated after landing of bug 1013904.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: horizontalTabs.patch

Found on OS X a unwanted padding on tabs. Removed with this patch.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8432238 [details] [diff] [review]
horizontalTabs.patch

Review of attachment 8432238 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the following changes.

::: browser/themes/linux/preferences/in-content/preferences.css
@@ +4,5 @@
>  
>  %include ../../../shared/incontentprefs/preferences.css
>  
> +tab[selected] {
> +  /* Override the margin-bottom for tab[selected]

This comment should just be made more generic since we are overriding not just the margin-bottom but also the border-radii from toolkit. You can just change it to /* Override styles for tab[selected] from toolkit/themes/linux/global/tabbox.css */

::: browser/themes/shared/incontentprefs/preferences.css
@@ +110,5 @@
>  }
>  
>  tab[selected] {
> +  background-color: #ebebeb;
> +  box-shadow: inset 0 -4px 0 0 #ff9500;

There is still a text-shadow on OSX with this patch applied. Please add a rule for `text-shadow: none;`.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

Fixed the comments.

Try: https://tbpl.mozilla.org/?tree=Try&rev=798689fed57d

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/a81285b5fabf

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a81285b5fabf

Comment 10

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Mac OSX 10.8.5 using latest Nightly 32.0a1 (buildID: 20140609030202).