1013722 - ContentSearch.jsm: TypeError: msg.target.messageManager is undefined

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Drew Willcoxon :adw]

Attachment: check for null messageManager

After bug 1009313 landed, when I run the TART test locally I often but not always see:

> A coding exception was thrown in a Promise resolution callback.
> 
> Full message: TypeError: msg.target.messageManager is undefined
> See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
> Full stack: this.ContentSearch._reply@resource:///modules/ContentSearch.jsm:123:5
> this.ContentSearch.onGetState@resource:///modules/ContentSearch.jsm:74:5
> this.ContentSearch.receiveMessage/<@resource:///modules/ContentSearch.jsm:68:9
> Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:863:11
> this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:742:7

TART rapidly opens and closes tabs, and the problem is that the asynchronicity added by bug 1009313 means that the browser that ContentSearch is responding to can be destroyed before ContentSearch responds to it.

So the chain of events looks like this: the browser sends a message ("GetState" in this case), ContentSearch.receiveMessage is called, receiveMessage calls _initService which is async, sometime before _initService finishes the browser is destroyed, _initService finishes, onGetState is called, _reply is called.

Comment 1

[Drew Willcoxon :adw]

Marco, could we add this to the current iteration?  It's a small fix to a problem introduced by another bug in the current iteration that has already landed.

Comment 2

[Marco Mucci [:MarcoM]]

Added to Iteration 32.2

Comment 4

[Drew Willcoxon :adw]

Bug 1014080 is an interesting manifestation of the same problem.

Comment 5

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/0685ea0268b7

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0685ea0268b7