1013724 - in-content preferences: style issue category sidebar

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Sören Hentzschel]

Attachment: preferences-2.png

The category sidebar of the in-content-preferences is a few pixel too small. The attached screenshot shows the issue, 400% zoom for better visibility of the issue.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: styleCategories.patch

Restyle according Project Chameleon. I removed the borders and use now a box-shadow to mark the selected category. This makes the orange part a correct rectangle. I removed also the inactive (gray) images like Chameleon is only using one shade of images.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8427214 [details] [diff] [review]
styleCategories.patch

Review of attachment 8427214 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the following changes.

::: browser/themes/shared/incontentprefs/preferences.css
@@ +491,5 @@
>  }
>  
>  .category {
>    -moz-appearance: none;
> +  color: #fbfbfb;

this should be 'color: #c1c1c1;' and it is missing 'transition: background-color 150ms;'.

@@ +508,2 @@
>    color: #f1f1f1;
> +  box-shadow: inset 4px 0 0 0 #FF9500;

the color for .category[selected] should be #f2f2f2;

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

Comments addressed.

Comment 5

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/integration/fx-team/rev/aa404fadf1b5

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/aa404fadf1b5

Comment 7

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Mac OSX 10.8.5 using latest Nightly 32.0a1 (buildID: 20140609030202).