Closed Bug 1013783 Opened 10 years ago Closed 10 years ago

Shared styles missing 2x icons

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jrburke, Unassigned)

Details

Attachments

(2 files)

Noticed when doing gaia builds with GAIA_DEV_PIXELS_PER_PX=2 for flame devices:

The email app references some images from the shared/styles area, and these do not have @2x versions, so they look blurry in those kinds of builds:

Seen when tapping "reply" while reading a message:

* shared/style/headers/images/icons/reply@2x.png
* shared/style/headers/images/icons/reply_all@2x.png

Seen in message list, the compose button in the upper right:

* shared/style/headers/images/icons/compose@2x.png
Attached file Email_Icon update.zip
Attached icons in @2x versions

* Reply icon while reading a message: reply@2x.png 
* Reply all icon: reply_all@2x.png 
* Next and last message button in the upper right while reading a message: email_back@2x.png, email_next@2x.png 
* Compose button in the message list: email_compose@2x.png 
* Send button in compose view: email_send@2x.png

Thanks!
Flags: needinfo?(jrburke)
Attached file GitHub pull request
Some 2x and 1.5x icons that were missing in the shared style area, ones that show up in email.

While the @2x icons may not needed for the Flame, the @1.5x icons are, and these are all part of the efforts for the general email 2.0 visual refresh tracked in bug 950208. With these icon additions, email will look good in 1, 1.5 and 2x targets when the other email-specific visual redesign changesets land.

tools/png_recompress.sh was used on the images before committing them to this pull request.
Attachment #8427956 - Flags: review?(arnau)
Flags: needinfo?(jrburke)
Comment on attachment 8427956 [details] [review]
GitHub pull request

cool, go ahead!
Attachment #8427956 - Flags: review?(arnau) → review+
Merged to master:
https://github.com/mozilla-b2g/gaia/commit/9c34f28aa8e11a0ac90fd2d150e5bfe6a05d3144

from pull request:
https://github.com/mozilla-b2g/gaia/pull/19608
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.