1013783 - Shared styles missing 2x icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[James Burke [:jrburke]]

Noticed when doing gaia builds with GAIA_DEV_PIXELS_PER_PX=2 for flame devices:

The email app references some images from the shared/styles area, and these do not have @2x versions, so they look blurry in those kinds of builds:

Seen when tapping "reply" while reading a message:

* shared/style/headers/images/icons/[e-mail]
* shared/style/headers/images/icons/[e-mail]

Seen in message list, the compose button in the upper right:

* shared/style/headers/images/icons/[e-mail]

Comment 1

[Fang Shih [:fang]]

Attachment: Email_Icon update.zip

Attached icons in @2x versions

* Reply icon while reading a message: [e-mail] 
* Reply all icon: [e-mail] 
* Next and last message button in the upper right while reading a message: [e-mail], [e-mail] 
* Compose button in the message list: [e-mail] 
* Send button in compose view: [e-mail]

Thanks!

Comment 2

[James Burke [:jrburke]]

Attachment: GitHub pull request

Some 2x and 1.5x icons that were missing in the shared style area, ones that show up in email.

While the @2x icons may not needed for the Flame, the @1.5x icons are, and these are all part of the efforts for the general email 2.0 visual refresh tracked in bug 950208. With these icon additions, email will look good in 1, 1.5 and 2x targets when the other email-specific visual redesign changesets land.

tools/png_recompress.sh was used on the images before committing them to this pull request.

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8427956 [details] [review]
GitHub pull request

cool, go ahead!

Comment 4

[James Burke [:jrburke]]

Merged to master:
https://github.com/mozilla-b2g/gaia/commit/9c34f28aa8e11a0ac90fd2d150e5bfe6a05d3144

from pull request:
https://github.com/mozilla-b2g/gaia/pull/19608