1013951 - Evernote authentication has stopped working in Notes+ in 1.4 onwards

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Notes, defect)

Description

[Chris Lord [:cwiiis]]

Syncing the 'Notes+' app (by Mozilla) with Evernote has stopped working in 1.4 and onwards. It still works correctly in 1.3. After authorising, in 1.4/master you're presented with a blank page and nothing happens. In 1.3, it correctly closes and goes back to the app, where syncing commences.

Comment 1

[Chris Lord [:cwiiis]]

It's worth noting that for each authorisation, I still get the e-mail saying that it was granted, it's just the app doesn't seem to acknowledge it.

Comment 2

[Dylan Oliver [:doliver]]

Attachment: phase2 PR

Ouch. Bad code, bad review, bad test on our last update. This should fix it.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

phase2: https://github.com/mozilla-b2g/notes/commit/8a31051535f180024557e9cc721a391936138167

Comment 4

[Dylan Oliver [:doliver]]

Thanks :cwiiis. This fix is now live in the marketplace, Notes+ v2.2.4.

Comment 5

[Chris Lord [:cwiiis]]

Great, fast work! I couldn't force it to update (is there a way of doing this? Checking for updates did nothing, I'm sure that used to work in 1.3...), but uninstalling it and reinstalling it, I can verify it's fixed.