1013971 - Use compare-locales' Parser classes in generate_sites.py

Status: RESOLVED WONTFIX

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Lucas Rocha (:lucasr)]

compare-locales contains more robust parsing utilities for .properties files. Let's use it once it gets merged into m-c (see bug 940103).

Comment 1

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

This applies to python/mozbuild/mozbuild/action/generate_suggestedsites.py and some future generate_browsersearch.py.

See Bug 1011620 and Bug 1065306, respectively.

Comment 2

[Roman Polyanovsky]

Hello,

Could I look into this as a good first bug?

Comment 3

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

(In reply to rpolyano from comment #2)
> Hello,
> 
> Could I look into this as a good first bug?

It's not trivial, but it might not be a good first bug.  What ended up happening is that we wrote a nice DotProperties class for doing this.  It's not as good as using compare-locales, but it's small and well-tested.  I don't see trying to improve this now.

See also the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1065306.

rpolyano: I don't have a great first bug for you that's similar -- try again?