Closed Bug 1013971 Opened 6 years ago Closed 2 years ago

Use compare-locales' Parser classes in generate_sites.py

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: lucasr, Unassigned, Mentored)

References

Details

(Keywords: good-first-bug)

compare-locales contains more robust parsing utilities for .properties files. Let's use it once it gets merged into m-c (see bug 940103).
This applies to python/mozbuild/mozbuild/action/generate_suggestedsites.py and some future generate_browsersearch.py.

See Bug 1011620 and Bug 1065306, respectively.
Depends on: 1065306
Mentor: l10n
Keywords: good-first-bug
Hello,

Could I look into this as a good first bug?
(In reply to rpolyano from comment #2)
> Hello,
> 
> Could I look into this as a good first bug?

It's not trivial, but it might not be a good first bug.  What ended up happening is that we wrote a nice DotProperties class for doing this.  It's not as good as using compare-locales, but it's small and well-tested.  I don't see trying to improve this now.

See also the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1065306.

rpolyano: I don't have a great first bug for you that's similar -- try again?
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox Build System
You need to log in before you can comment on or make changes to this bug.