Closed Bug 1014054 Opened 7 years ago Closed 6 years ago

Duck Duck Go, artifacts remain on screen after resize

Categories

(Firefox for Android :: Toolbar, defect)

32 Branch
ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 32
Tracking Status
fennec 32+ ---

People

(Reporter: aaronmt, Assigned: kats)

References

Details

(Whiteboard: gfx)

Attachments

(2 files)

Attached image screenshot.png
See screenshot.

On my Nexus 5 (Android 4.4.2), I am frequently seeing artifacts remain on screen after a resize from keyboard focus on the search field.

The only way to repaint the screen is by scrolling.

--
Nightly (05/21)
You're seeing artifacts after putting focus in the search field? Or after removing focus from the search field? (i.e. are the artifacts shown in place of the keyboard?)
When the keyboard is dismissed hitting the back button on my Nexus 5
This appears to be a regression from bug 1001438, I see it as well.
Assignee: nobody → bugmail.mozilla
tracking-fennec: ? → 32+
Attached patch PatchSplinter Review
This seems to fix it.

Try push including this change at https://tbpl.mozilla.org/?tree=Try&rev=37a728754cdc
Attachment #8427163 - Flags: review?(chrislord.net)
Comment on attachment 8427163 [details] [diff] [review]
Patch

Review of attachment 8427163 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Interesting artifacts when this is broken, I guess you end up with a valid region that's smaller than the visible region? I'd quite like to know what causes those artifacts...
Attachment #8427163 - Flags: review?(chrislord.net) → review+
Yeah, the critical displayport ended up being smaller than the viewport, and so it would hit the code at http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/gfx/GeckoLayerClient.java?rev=1b39c3a55620#545 and stop painting the critical area.
https://hg.mozilla.org/mozilla-central/rev/1139dcf8c2ea
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.