1014054 - Duck Duck Go, artifacts remain on screen after resize

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

See screenshot.

On my Nexus 5 (Android 4.4.2), I am frequently seeing artifacts remain on screen after a resize from keyboard focus on the search field.

The only way to repaint the screen is by scrolling.

--
Nightly (05/21)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

You're seeing artifacts after putting focus in the search field? Or after removing focus from the search field? (i.e. are the artifacts shown in place of the keyboard?)

Comment 2

[Aaron Train [:aaronmt]]

When the keyboard is dismissed hitting the back button on my Nexus 5

Comment 3

[Kartikaya Gupta (email:[e-mail])]

This appears to be a regression from bug 1001438, I see it as well.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

This seems to fix it.

Try push including this change at https://tbpl.mozilla.org/?tree=Try&rev=37a728754cdc

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 8427163 [details] [diff] [review]
Patch

Review of attachment 8427163 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Interesting artifacts when this is broken, I guess you end up with a valid region that's smaller than the visible region? I'd quite like to know what causes those artifacts...

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Yeah, the critical displayport ended up being smaller than the viewport, and so it would hit the code at http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/gfx/GeckoLayerClient.java?rev=1b39c3a55620#545 and stop painting the critical area.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1139dcf8c2ea

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1139dcf8c2ea