1014142 - URL Keyboard should following the recommendations

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Raniere Silva]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release)
Build ID: 20140518030203

Steps to reproduce:

1. Install Keyboard application UI
   - open browser app,
   - enter http://bit.ly/UgIMN4
   - follow the prompts on your phone to install the UI Test app
2. Go to homescreen and open "UI tests"
3. Select "Keyboard test" from the "UI tests" list
4. Enter in "Input type=url"
5. Verify the keyboard has following eight buttons on the bottom row:
 "?123", "/", "-", "_", ":", ".com", ".", "go" (based on Open Web Device - Keyboard Recommendations [1])

[1] https://wiki.mozilla.org/images/2/20/Keyboard_Specs.pdf


Actual results:

The following five are presented:
"?123", ".", "/", ".com", "enter symbol".

Comment 1

[Raniere Silva]

Attachment: Partial fix for URL Keyboard

Comment 2

[Raniere Silva]

Attachment: Partial fix for URL Keyboard

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8426476 [details] [review]
Partial fix for URL Keyboard

I am fine with this change. r+.

Raniere, thanks for your contribution!

--
Omega, could you please help review this, since I am not sure if we have UX update on the URL keyboard.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Filed a follow-up bug for .com popup, bug 1014371.

Comment 5

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8426476 [details] [review]
Partial fix for URL Keyboard

Hi Raniere,
Please refer to the latest UX spec at bug 983043.
The URL's bottom line should be:
[12&][En][/][SPACE][.][ENTER]

(Notice that there is a little error in the spec. The last key should be ENTER icon, not GO.)

Comment 6

[Raniere Silva]

Attachment: URL Keyboard based on specs v1.8

Comment 7

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8427276 [details] [review]
URL Keyboard based on specs v1.8

Nice, thanks!

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8427276 [details] [review]
URL Keyboard based on specs v1.8

While this change is good enough to get a r+, could you please help take a look at the gaia-ui-test, which is our integration test?
https://travis-ci.org/mozilla-b2g/gaia/jobs/25822070

Let me know if you have any questions about it.
Thank you.

--
The marionette js failure should be irrelevant here, you could try to rebase your patch to get that passed.
https://travis-ci.org/mozilla-b2g/gaia/jobs/25822069

Comment 9

[Raniere Silva]

Attachment: 8427276: URL Keyboard based on specs v2.0

Rudy, this is the previous patch with an update to integration test (remote the test to '.com' key since it don't exist anymore.

Did I request another review from UI?

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8429355 [details] [review]
8427276: URL Keyboard based on specs v2.0

r=me, and also carry forward the ui-review+ here.

--
Raniere,

Thanks for working on this!
Just a soft reminder that next time you may keep the same attachment, since it corresponds to the same pull request.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/969d35114eed0eabbd0fe7c01fad19a2df0097b5