1014179 - Always draw the OS X titlebar ourselves.

Status: NEW

(Firefox :: Theme, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

On OS X, we draw the titlebar for Firefox ourselves in the following cases:

1) Tabs on top
2) Tabs on bottom, lightweight theme enabled
3) Customize mode
4) Popup-window, lightweight theme enabled

The only cases where we draw the native titlebar is:

1) Tabs on bottom, no lightweight theme
2) Popup windows, no lightweight theme

We have a bunch of logic (see updateTitlebarDisplay in browser.js) to do the work to set the chromemargin attribute on the main-window, in order to tell the widget layer whether or not to just let the OS draw the native titlebar.

I think we could greatly simplify things if we just drew the titlebar ourselves the whole time. This would mean all (or most) of the titlebar logic could (theoretically) go into CSS. It would mean, however, that until bug 944836 lands, if the main-thread is blocked, the window would be non-draggable - so this bug is blocked by bug 944836.