Remove unused BookmarkJSONUtils from services/sync/tps/extensions/tps/resource/modules/bookmarks.jsm
RESOLVED
FIXED
in mozilla32
Status
()
People
(Reporter: mak, Assigned: shashank)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [good first bug][mentor=mak][lang=js])
Attachments
(1 attachment)
we are importing the module but nothing is using it, we should stop importing it. It's a very trivial patch, fine to get feeling of how the development process works.
|
Assignee | |
Comment 1•5 years ago
|
||
var DumpBookmarks = function TPS_Bookmarks__DumpBookmarks() {...
...
Logger.logInfo("Dumping Bookmarks...\n" + JSON.stringify(bookmarks) + "\n\n\");
Isn't this using the BookmarkJSONUtils?|
|
Assignee | |
Comment 2•5 years ago
|
||
Deleted unused BookmarkJSONUtils from services/sync/tps/extensions\ /tps/resource/modules/bookmarks.jsm r=mak
Attachment #8427289 -
Flags: review?(mak77)
|
Reporter | |
Updated•5 years ago
|
Attachment #8427289 -
Flags: review?(mak77) → review+
|
|
Reporter | |
Comment 3•5 years ago
|
||
For sheriffs: this is just removing an unused module import, so not going to waste a try run just for it. I double verified that nothing is trying to use the module there.
Keywords: checkin-needed
|
|
Reporter | |
Updated•5 years ago
|
Assignee: nobody → shashank16392
Status: NEW → ASSIGNED
|
||
Comment 4•5 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/db314d15645b
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=mak][lang=js] → [good first bug][mentor=mak][lang=js][fixed-in-fx-team]
|
||
Comment 5•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/db314d15645b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=mak][lang=js][fixed-in-fx-team] → [good first bug][mentor=mak][lang=js]
Target Milestone: --- → mozilla32
|
||
Updated•9 months ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•