1014186 - Remove unused BookmarkJSONUtils from services/sync/tps/extensions/tps/resource/modules/bookmarks.jsm

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Marco Bonardo [:mak]]

we are importing the module but nothing is using it, we should stop importing it.
It's a very trivial patch, fine to get feeling of how the development process works.

Comment 1

[Shashank VRSN Sabniveesu]

var DumpBookmarks = function TPS_Bookmarks__DumpBookmarks() {...
...
    Logger.logInfo("Dumping Bookmarks...\n" + JSON.stringify(bookmarks) + "\n\n\");


Isn't this using the BookmarkJSONUtils?

Comment 2

[Shashank VRSN Sabniveesu]

Attachment: BUG1014186.patch: Remove unused BookmarkJSONUtils from services/sync/tps/extensions\ /tps/resource/modules/bookmarks.jsm r=mak

Deleted unused BookmarkJSONUtils from services/sync/tps/extensions\ /tps/resource/modules/bookmarks.jsm r=mak

Comment 3

[Marco Bonardo [:mak]]

For sheriffs: this is just removing an unused module import, so not going to waste a try run just for it. I double verified that nothing is trying to use the module there.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/db314d15645b

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/db314d15645b