Closed Bug 1014186 Opened 7 years ago Closed 7 years ago

Remove unused BookmarkJSONUtils from services/sync/tps/extensions/tps/resource/modules/bookmarks.jsm

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: mak, Assigned: shashank)

Details

(Whiteboard: [good first bug][mentor=mak][lang=js])

Attachments

(1 file)

BUG1014186.patch: Remove unused BookmarkJSONUtils from services/sync/tps/extensions\ /tps/resource/modules/bookmarks.jsm r=mak
1.22 KB, patch
mak
: review+
Details | Diff | Splinter Review 
we are importing the module but nothing is using it, we should stop importing it.
It's a very trivial patch, fine to get feeling of how the development process works.
var DumpBookmarks = function TPS_Bookmarks__DumpBookmarks() {...
...
    Logger.logInfo("Dumping Bookmarks...\n" + JSON.stringify(bookmarks) + "\n\n\");


Isn't this using the BookmarkJSONUtils?
Deleted unused BookmarkJSONUtils from services/sync/tps/extensions\ /tps/resource/modules/bookmarks.jsm r=mak
Attachment #8427289 - Flags: review?(mak77)
Attachment #8427289 - Flags: review?(mak77) → review+
For sheriffs: this is just removing an unused module import, so not going to waste a try run just for it. I double verified that nothing is trying to use the module there.
Keywords: checkin-needed
Assignee: nobody → shashank16392
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/fx-team/rev/db314d15645b
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=mak][lang=js] → [good first bug][mentor=mak][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/db314d15645b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=mak][lang=js][fixed-in-fx-team] → [good first bug][mentor=mak][lang=js]
Target Milestone: --- → mozilla32
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.