1014188 - Stop importing PlacesBackups and BookmarkJSONUtils in PlacesUtils

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

these modules are imported but unused in PlacesUtils, we should remove the import. The patch should be trivial.

Comment 1

[Shashank VRSN Sabniveesu]

(In reply to Marco Bonardo [:mak] from comment #0)
> these modules are imported but unused in PlacesUtils, we should remove the
> import. The patch should be trivial.

Is it just removing these lines in toolkit/components/places/PlacesUtils.jsm ?

XPCOMUtils.defineLazyModuleGetter(this, "BookmarkJSONUtils",
                                  "resource://gre/modules/BookmarkJSONUtils.jsm\
");

XPCOMUtils.defineLazyModuleGetter(this, "PlacesBackups",
                                  "resource://gre/modules/PlacesBackups.jsm");

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Yes, that's it.

Comment 3

[Shashank VRSN Sabniveesu]

Attachment: Removed imports: 'PlacesBackups' and 'BookmarkJSONUtils' in 'PlacesUtils.jsm'

Removed imports: 'PlacesBackups' and 'BookmarkJSONUtils' in 'PlacesUtils.jsm'

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8426525 [details] [diff] [review]
Removed imports: 'PlacesBackups' and 'BookmarkJSONUtils' in 'PlacesUtils.jsm'

Review of attachment 8426525 [details] [diff] [review]:
-----------------------------------------------------------------

thank you very much for your contribution!  If you have any questions feel free to ask, you may find me in the #fx-team channel on mozilla irc server or mail me.  You can also ask more general involvement and coding questions in the #introduction channel, that is dedicated to new code contributors.

please just add r=mak at the end of the commit message so that the patch is ready for check-in.
Then set the checkin-needed keyword in the keywords field so that a tree sheriff will take care of pushing the patch for you.

I just pushed to try to run tests on it: https://tbpl.mozilla.org/?tree=Try&rev=a654029cfd86

Comment 5

[Shashank VRSN Sabniveesu]

Attachment: BUG 1014188: Removed imports: 'PlacesBackups' and 'BookmarkJSONUtils' in 'PlacesUtils.jsm'

BUG 1014188: Removed imports: 'PlacesBackups' and 'BookmarkJSONUtils' in 'PlacesUtils.jsm'

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/2c80f01b0e44

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2c80f01b0e44