Closed
Bug 1014188
Opened 11 years ago
Closed 11 years ago
Stop importing PlacesBackups and BookmarkJSONUtils in PlacesUtils
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: mak, Assigned: shashank)
Details
(Whiteboard: [good first bug][mentor=mak][lang=js])
Attachments
(2 files)
|
1.38 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
|
1.39 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
these modules are imported but unused in PlacesUtils, we should remove the import. The patch should be trivial.
|
Assignee | |
Comment 1•11 years ago
|
||
(In reply to Marco Bonardo [:mak] from comment #0)
> these modules are imported but unused in PlacesUtils, we should remove the
> import. The patch should be trivial.
Is it just removing these lines in toolkit/components/places/PlacesUtils.jsm ?
XPCOMUtils.defineLazyModuleGetter(this, "BookmarkJSONUtils",
"resource://gre/modules/BookmarkJSONUtils.jsm\
");
XPCOMUtils.defineLazyModuleGetter(this, "PlacesBackups",
"resource://gre/modules/PlacesBackups.jsm");
Flags: needinfo?(mak77)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Removed imports: 'PlacesBackups' and 'BookmarkJSONUtils' in 'PlacesUtils.jsm'
Attachment #8426525 -
Flags: review?(mak77)
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → shashank16392
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 4•11 years ago
|
||
Comment on attachment 8426525 [details] [diff] [review]
Removed imports: 'PlacesBackups' and 'BookmarkJSONUtils' in 'PlacesUtils.jsm'
Review of attachment 8426525 [details] [diff] [review]:
-----------------------------------------------------------------
thank you very much for your contribution! If you have any questions feel free to ask, you may find me in the #fx-team channel on mozilla irc server or mail me. You can also ask more general involvement and coding questions in the #introduction channel, that is dedicated to new code contributors.
please just add r=mak at the end of the commit message so that the patch is ready for check-in.
Then set the checkin-needed keyword in the keywords field so that a tree sheriff will take care of pushing the patch for you.
I just pushed to try to run tests on it: https://tbpl.mozilla.org/?tree=Try&rev=a654029cfd86
Attachment #8426525 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
BUG 1014188: Removed imports: 'PlacesBackups' and 'BookmarkJSONUtils' in 'PlacesUtils.jsm'
Attachment #8426584 -
Flags: review?(mak77)
Attachment #8426584 -
Flags: checkin?
Flags: needinfo?(mak77)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #8426584 -
Flags: review?(mak77)
Attachment #8426584 -
Flags: review+
Attachment #8426584 -
Flags: checkin?
|
|
Reporter | |
Updated•11 years ago
|
Flags: needinfo?(mak77)
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=mak][lang=js] → [good first bug][mentor=mak][lang=js][fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=mak][lang=js][fixed-in-fx-team] → [good first bug][mentor=mak][lang=js]
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•