Closed Bug 1014198 Opened 10 years ago Closed 10 years ago

servo linux builder needs /tools/gcc-4.7.3-0moz1/bin in its PATH

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jack, Assigned: bhearsum)

Details

Attachments

(2 files)

Servo correctly asks for the right GCC package now, but configure/make can't find it since it's in a non-standard place.
I think this should work with a config similar to that in https://github.com/mozilla/servo/commit/572eebd8df0b0a54c9aaadd1fa98ba78d0d4d0e7

I think PATH will end up needing to be "/blah:%(PATH)s" to prepend instead of append though...
Assignee: nobody → bhearsum
Attachment #8426528 - Flags: review?(aki)
Attachment #8426528 - Flags: review?(aki) → review+
Comment on attachment 8426528 [details] [diff] [review]
pass env from config to run command

Landed this on default + production. I'm out for the day now, but you can give this another try with the PATH noted in comment #1, Jack. If it still has issues I should be able to look again tomorrow.
Attachment #8426528 - Flags: checked-in+
Attached patch query_envSplinter Review
Attachment #8427155 - Flags: review?(bhearsum)
Comment on attachment 8427155 [details] [diff] [review]
query_env

Review of attachment 8427155 [details] [diff] [review]:
-----------------------------------------------------------------

Thank for the help, Aki. I landed this (default+production).
Attachment #8427155 - Flags: review?(bhearsum)
Attachment #8427155 - Flags: review+
Attachment #8427155 - Flags: checked-in+
The latest build got the right GCC. It still failed, but I think for different reasons (maybe missing a -dev library?).
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Something here went live today
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: