Open Bug 1014229 Opened 8 years ago Updated 5 years ago

Stop using a panelmultiview when displaying subviews as standalone panels

Categories

(Firefox :: Toolbars and Customization, defect)

29 Branch
defect
Not set
normal

Tracking

()

People

(Reporter: Gijs, Unassigned)

References

Details

We shouldn't really need to have a panelmultiview for this case at all; we never show any other subview in the panel.

Mike, do you remember why we did it this way? Why aren't we just sticking the panelview into a <panel> directly? :-)
Flags: needinfo?(mconley)
Flags: firefox-backlog+
(In reply to :Gijs Kruitbosch from comment #0)
> We shouldn't really need to have a panelmultiview for this case at all; we
> never show any other subview in the panel.
> 
> Mike, do you remember why we did it this way? Why aren't we just sticking
> the panelview into a <panel> directly? :-)

I think because at least at one point, the bookmarks menu was going to work like this:

If the bookmarks menu subview is opened in the menu panel, clicking folders causes us to open the Library.
If the bookmarks menu subview is opened on its own, clicking folders should cause us to open a subview with the folder contents.

That plan eventually got scrapped - so I think what we're seeing here is a fragment of a somewhat baked idea that never shipped, or was bailed out on. We're good to chuck the fragment out.
Flags: needinfo?(mconley)
Whiteboard: [photon]
Flags: firefox-backlog+
Whiteboard: [photon]
You need to log in before you can comment on or make changes to this bug.