1014274 - Loads v0.3 requires pexpect to make the --ssh functionality work correctly

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[James Bonacci [:jbonacci]]

./bin/loads-runner --server-url=BLAH -u 1 --hits=1 --agents=1 --user-id=BLAH --ssh=BLAH loadtest.TestLoop.test_all
To use --ssh you need pexpect
Try: pip install pexpect

We can do this manually, so either:
1. Update the README.md file
2. Add this as a pre-req for the "make install" portion of the load tests...

Comment 1

[James Bonacci [:jbonacci]]

Hmmmmm....
So, I can not get past this error on Mac:

loadtests$ sudo pip install pexpect
Password:
Downloading/unpacking pexpect
  Downloading pexpect-3.2.tar.gz (131kB): 131kB downloaded
  Running setup.py egg_info for package pexpect
    
Installing collected packages: pexpect
  Running setup.py install for pexpect
    
Successfully installed pexpect
Cleaning up...

loadtests$ ./bin/loads-runner --server-url=BLAH -u 1 --hits=1 --agents=1 --user-id=BLAH --ssh=BLAH loadtest.TestLoop.test_all
To use --ssh you need pexpect
Try: pip install pexpect

I know I have seen this before, but I can not remember how I got around this...


So, maybe, as with https://github.com/mozilla/browserid-verifier/blob/master/loadtest/Makefile
We need to do this:

build:
$(INSTALL) pexpect


Separately, we should investigate why this error happens even if pexpect is installed...

Comment 2

[James Bonacci [:jbonacci]]

More specifically, I think we need to install pexpect within the virtualenv.

Comment 3

[Rémy Hubscher (:natim)]

You should use ./bin/pip install pexpect

Comment 4

[James Bonacci [:jbonacci]]

OK. That got me to a point where I can actually run a test. Thanks!
We need to build this into the 'make install' process to save the user a step...
See bug 1014271

Comment 5

[Alexis Metaireau (:alexis)]

This is the case now. Fixed in https://github.com/mozilla-services/loop-server/commit/058f037c8354ee9729fb71f95fc0156e23674bcf

Comment 6

[James Bonacci [:jbonacci]]

Working correctly now.