1014283 - Finish BrowserHealthRecorder initialization after distribution processing

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Richard Newman [:rnewman]]

Rather than poking at the distribution directly, relying on order of execution, we should wait until it's loaded!

Comment 1

[Richard Newman [:rnewman]]

Attachment: Finish BrowserHealthRecorder initialization after distribution processing. v1

Nice and simple.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Finish BrowserHealthRecorder initialization after distribution processing.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8426716 [details] [diff] [review]
Finish BrowserHealthRecorder initialization after distribution processing.

I want to land this alongside Bug 1014242, so I guess I should get it reviewed!

I've tested this locally, and some builds have gone through Try with this patch.

Comment 4

[:Margaret Leibovic]

Comment on attachment 8426716 [details] [diff] [review]
Finish BrowserHealthRecorder initialization after distribution processing.

Review of attachment 8426716 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like an improvement.

::: mobile/android/base/health/BrowserHealthRecorder.java
@@ -524,5 @@
>          this.profileCache.setAppLocale(appLocale);
>  
>          // Because the distribution lookup can take some time, do it at the end of
>          // our background startup work, along with the Gecko snapshot fetch.
> -        final GeckoEventListener self = this;

Happy to see this line go.

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/abc445f4c325

Comment 6

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/abc445f4c325