Closed Bug 1014283 Opened 6 years ago Closed 6 years ago

Finish BrowserHealthRecorder initialization after distribution processing

Categories

(Firefox for Android :: Data Providers, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 32

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file, 1 obsolete file)

Rather than poking at the distribution directly, relying on order of execution, we should wait until it's loaded!
Attachment #8426621 - Attachment is obsolete: true
No longer depends on: 1013684
Comment on attachment 8426716 [details] [diff] [review]
Finish BrowserHealthRecorder initialization after distribution processing.

I want to land this alongside Bug 1014242, so I guess I should get it reviewed!

I've tested this locally, and some builds have gone through Try with this patch.
Attachment #8426716 - Flags: review?(margaret.leibovic)
Comment on attachment 8426716 [details] [diff] [review]
Finish BrowserHealthRecorder initialization after distribution processing.

Review of attachment 8426716 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like an improvement.

::: mobile/android/base/health/BrowserHealthRecorder.java
@@ -524,5 @@
>          this.profileCache.setAppLocale(appLocale);
>  
>          // Because the distribution lookup can take some time, do it at the end of
>          // our background startup work, along with the Gecko snapshot fetch.
> -        final GeckoEventListener self = this;

Happy to see this line go.
Attachment #8426716 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/abc445f4c325
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
You need to log in before you can comment on or make changes to this bug.