Closed
Bug 1014290
Opened 10 years ago
Closed 10 years ago
[patch] Remove unreachable case in setprop MIR building.
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: vstamour, Assigned: vstamour)
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
efaust
:
review+
|
Details | Diff | Splinter Review |
Because emitting a polymorphic cache can't fail, the fallback case (emitting a call) is unreachable. Seems to be a result of git commit b37daef8808 removing a failure case in polymorphic cache emission.
|
Assignee | |
Updated•10 years ago
|
Attachment #8426656 -
Flags: review?(efaustbmo)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8426656 [details] [diff] [review] 0001-Remove-unreachable-case-in-setprop-MIR-building.patch Review of attachment 8426656 [details] [diff] [review]: ----------------------------------------------------------------- Yep. This looks sane. r=me.
Attachment #8426656 -
Flags: review?(efaustbmo) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 2•10 years ago
|
||
Do you have a link to a recent Try run by chance? :)
Assignee: nobody → vstamour
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•10 years ago
|
||
I don't, and I don't think I have access to the Try server. I'll look into that.
|
|
Assignee | |
Comment 4•10 years ago
|
||
Try run from yesterday: https://tbpl.mozilla.org/?tree=Try&rev=340995e357f9 It has a few failures, but none that look related to the change.
|
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cfd4978a9a37
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•