[patch] Remove unreachable case in setprop MIR building.

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vstamour, Assigned: vstamour)

Tracking

Trunk
mozilla32
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Because emitting a polymorphic cache can't fail, the fallback case (emitting a call) is unreachable. Seems to be a result of git commit b37daef8808 removing a failure case in polymorphic cache emission.
Attachment #8426656 - Flags: review?(efaustbmo)
Comment on attachment 8426656 [details] [diff] [review]
0001-Remove-unreachable-case-in-setprop-MIR-building.patch

Review of attachment 8426656 [details] [diff] [review]:
-----------------------------------------------------------------

Yep. This looks sane. r=me.
Attachment #8426656 - Flags: review?(efaustbmo) → review+
Keywords: checkin-needed
Do you have a link to a recent Try run by chance? :)
Assignee: nobody → vstamour
Keywords: checkin-needed
I don't, and I don't think I have access to the Try server. I'll look into that.
Try run from yesterday: https://tbpl.mozilla.org/?tree=Try&rev=340995e357f9
It has a few failures, but none that look related to the change.
https://hg.mozilla.org/mozilla-central/rev/cfd4978a9a37
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.