1014317 - Port the PR_SET_VMA_ANON_NAME patch to the B2G emulator kernel (3.4)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Android has a kernel patch that allows giving anonymous memory regions names that appear in /proc/N/maps, which they've already shipped for at least Nexus 4 and Nexus 5 (KitKat builds).  We think it would be useful for Gecko (bug 1011350), but development is impaired by limited availability of the feature on B2G devices.  But there's no reason we can't apply it to the emulator.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/kernel_goldfish/pull/10

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/platform_prebuilts_qemu-kernel/pull/7

f? because it'd be nice to get confirmation that this does what we want before merging.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8427404 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/platform_prebuilts_qemu-kernel/pull/7

I'm not sure what feedback you're after. The second patch on github appears to be modifying only binary files. The first patch appears to be adding the feature we want.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8427404 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/platform_prebuilts_qemu-kernel/pull/7

This is the repo that's actually in the checkout, and the emulator reads the appropriate file from it when booting, which is why I put the f? here instead of on the source.

I've tested it myself, by creating a first-draft patch for bug 1011350, and it works.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Don't know what's wrong yet.  I can't pull that git commit from github.

Comment 6

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Vicamo Yang [:vicamo][:vyang] (PTO May 17 - Jun 1)) from comment #5)
> Don't know what's wrong yet.  I can't pull that git commit from github.

The revision referenced in the platform_prebuilts_qemu-kernel PR (b0eb2b3463fa720276653ce91d1822c91fff0aa5) won't exist in https://github.com/mozilla-b2g/kernel_goldfish until/unless https://github.com/mozilla-b2g/kernel_goldfish/pull/10 is merged.  Currently it should be available from https://github.com/jld/kernel_goldfish

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Jed Davis [:jld] from comment #6)
> (In reply to Vicamo Yang [:vicamo][:vyang] (PTO May 17 - Jun 1)) from
> comment #5)
> > Don't know what's wrong yet.  I can't pull that git commit from github.
> 
> The revision referenced in the platform_prebuilts_qemu-kernel PR
> (b0eb2b3463fa720276653ce91d1822c91fff0aa5) won't exist in
> https://github.com/mozilla-b2g/kernel_goldfish until/unless
> https://github.com/mozilla-b2g/kernel_goldfish/pull/10 is merged.  Currently
> it should be available from https://github.com/jld/kernel_goldfish

I didn't mean that.  Somehow I can't pull your, jld, commits into prebuilts/qemu-kernel directly.  Could be some network problem.  Anyway, I've cloned it cleanly and it's no longer a problem.

Comment 8

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

https://github.com/mozilla-b2g/kernel_goldfish/commit/c39900240bccb67e296bd39d81d966d409f74a5c
https://github.com/mozilla-b2g/platform_prebuilts_qemu-kernel/commit/1a982dd6b02b939c75cd116d2d9de97e6ff3de24