1014397 - "sr=[DOM peer]" should be allowed as well as "r=[DOM peer]" for webidl changes

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Eric Chou [:ericchou] [:echou]]

I tried to push my patches of bug 942104 which modified .webidl, but I got error messages as below

=================

remote: WebIDL file dom/webidl/BluetoothDiscoveryStateChangedEvent.webidl altered in changeset 16a8f3e1d42b without DOM peer review
remote: WebIDL file dom/webidl/BluetoothAdapter.webidl altered in changeset 29029a587918 without DOM peer review
remote: WebIDL file dom/webidl/BluetoothAdapter.webidl altered in changeset cdb5622da4d7 without DOM peer review
remote: WebIDL file dom/webidl/BluetoothDevice.webidl altered in changeset cdb5622da4d7 without DOM peer review
remote: WebIDL file dom/webidl/BluetoothDeviceEvent.webidl altered in changeset cdb5622da4d7 without DOM peer review
remote: WebIDL file dom/webidl/BluetoothManager.webidl altered in changeset cdb5622da4d7 without DOM peer review
remote: WebIDL file dom/webidl/BluetoothStatusChangedEvent.webidl altered in changeset cdb5622da4d7 without DOM peer review
remote: 
remote: 
Changes to WebIDL files in this repo require review from a DOM peer in the form of r=...
This is to ensure that we behave responsibly with exposing new Web APIs. We appreciate your understanding..

=================

I did ask DOM peer for review and put 'sr=mrbkap' and 'sr=bz' at the end of the patch summary, however it seems that the parser only accept 'r=' but not 'sr='. Talked to bz and he told me to file a bug.

Please reassign the component if 'Tinderbox' is not the right one.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8426992 [details] [diff] [review]
Patch (v1)

Review of attachment 8426992 [details] [diff] [review]:
-----------------------------------------------------------------

Feel free to continue to land trivial changes to this hook without review.

Comment 3

[(no longer active)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Comment on attachment 8426992 [details] [diff] [review]
> Patch (v1)
> 
> Review of attachment 8426992 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Feel free to continue to land trivial changes to this hook without review.

Thanks!

Comment 4

[(no longer active)]

http://hg.mozilla.org/hgcustom/hghooks/rev/7d2946588c37

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/1a73fc4c47f0