Closed
Bug 1014404
Opened 11 years ago
Closed 11 years ago
Remove mocha.globals declarations from unit tests
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S3 (6june)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=1],[systemsfe])
Attachments
(1 file)
Bug 1014180 is landing which will remove the mocha leak detection in our test files. After this lands we should probably remove the mocha.globals() calls in our unit tests. I thought about keeping them in case we wanted this for the future, but they would be useless and probably get out of date.
This shouldn't be too risky, so a single PR should be able to remove all of them.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [p=1],[systemsfe]
Target Milestone: --- → 2.0 S3 (6june)
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8428276 [details] [review]
Github pull request
These are no longer needed so we should remove them. Review stamp anyone? Thanks!
Attachment #8428276 -
Flags: review?(jlal)
Attachment #8428276 -
Flags: review?(felash)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8428276 [details] [review]
Github pull request
julien is out don't think he minds if i r+
Attachment #8428276 -
Flags: review?(jlal)
Attachment #8428276 -
Flags: review?(felash)
Attachment #8428276 -
Flags: review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Thanks!! Landed: https://github.com/mozilla-b2g/gaia/commit/f46737df7c8b98df9e3d85646955ef7f90c04cec
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Comment 5•11 years ago
|
||
Thanks for cleaning up!
You need to log in
before you can comment on or make changes to this bug.
Description
•