1014408 - B2G RIL: show empty APN for 405-05 SIM.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[shawn ku [:sku]]

Currently, Gecko will treat MNC as length 3 (see [1]) if EF_AD does not specify the length on the 4th byte (see [2]) for those MCC equals to 405 case.

However, AOSP made a table (see [3]) to handle those exception cases.
It would be helpful if Gecko can provide such mechanism to avoid empty APN problem.


[1] - http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_consts.js?from=ril_consts.js&case=true#2995
[2] - 3GPP TS 31.102, 4.2.18 EFAD (Administrative Data)
[3] - http://code.metager.de/source/xref/android/4.0.3/frameworks-base/telephony/java/com/android/internal/telephony/gsm/SIMRecords.java#155

Comment 1

[shawn ku [:sku]]

Attachment: Bug 1014408 - B2G RIL: show empty APN for 404-05 SIM.

Comment 2

[shawn ku [:sku]]

Attachment: Bug 1014408 - B2G RIL: show empty APN for 404-05 SIM.

Comment 3

[shawn ku [:sku]]

Comment on attachment 8429900 [details] [diff] [review]
Bug 1014408 - B2G RIL: show empty APN for 404-05 SIM.

Review of attachment 8429900 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Hsinyi:
 May I have your comment on this patch?

Thanks!!
Shawn

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8429900 [details] [diff] [review]
Bug 1014408 - B2G RIL: show empty APN for 404-05 SIM.

Review of attachment 8429900 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_consts.js
@@ +2971,5 @@
>  this.INFO_REC_EXTENDED_DISPLAY_CONNECTED_NUMBER = 0x9A;
>  this.INFO_REC_EXTENDED_DISPLAY_TEXT = 0x9B;
>  
>  /**
> + * The table for MCC/MNC which the length of MNC is 3.

Looks it's inevitable that we need to maintain a table. I am fine with the concept of the solution. However, we all know the main issue behind is the update! Let's keep this in mind until we figure out a good update mechanism. :)

@@ +2977,5 @@
> + * This table is built from below links.
> + * - http://www.itu.int/pub/T-SP-E.212B-2013
> + * - http://en.wikipedia.org/wiki/Mobile_Network_Code
> + */
> +this.PLMN_HAVING_3DIGITS_MNC = [

I am thinking about a 2-dimention table. I.e., use "MCC" as the 1st index, then check MNC; in this way, if the MCC isn't 405, we don't need to go through these 100+ items.

Comment 5

[shawn ku [:sku]]

Attachment: Bug 1014408 - B2G RIL: show empty APN for 404-05 SIM. v2.

Comment 6

[shawn ku [:sku]]

Attachment: Bug 1014408 - B2G RIL: show empty APN for 405-05 SIM. v2.

Comment 7

[shawn ku [:sku]]

(In reply to Hsin-Yi Tsai (OOO 5/30 ~ 6/8) [:hsinyi] from comment #4)
> Comment on attachment 8429900 [details] [diff] [review]
> Bug 1014408 - B2G RIL: show empty APN for 404-05 SIM.
> 
> Review of attachment 8429900 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/ril_consts.js
> @@ +2971,5 @@
> >  this.INFO_REC_EXTENDED_DISPLAY_CONNECTED_NUMBER = 0x9A;
> >  this.INFO_REC_EXTENDED_DISPLAY_TEXT = 0x9B;
> >  
> >  /**
> > + * The table for MCC/MNC which the length of MNC is 3.
> 
> Looks it's inevitable that we need to maintain a table. I am fine with the
> concept of the solution. However, we all know the main issue behind is the
> update! Let's keep this in mind until we figure out a good update mechanism.
> :)

Yes, agree with you. However, the 4th byte of EF_AD is mandatory for new SIM (begin from R99). There should be no issue on new card, but we still need to figure out how to handle those SIM w/o the 4th byte of EF_AD if the table we created has anything wrong anyway.

> 
> @@ +2977,5 @@
> > + * This table is built from below links.
> > + * - http://www.itu.int/pub/T-SP-E.212B-2013
> > + * - http://en.wikipedia.org/wiki/Mobile_Network_Code
> > + */
> > +this.PLMN_HAVING_3DIGITS_MNC = [
> 
> I am thinking about a 2-dimention table. I.e., use "MCC" as the 1st index,
> then check MNC; in this way, if the MCC isn't 405, we don't need to go
> through these 100+ items.

Address in new patch. Please take a look on it.:)

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8430515 [details] [diff] [review]
Bug 1014408 - B2G RIL: show empty APN for 405-05 SIM. v2.

Review of attachment 8430515 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_consts.js
@@ +2975,5 @@
> + * The table for MCC/MNC which the length of MNC is 3.
> + *
> + * This table is built from below links.
> + * - http://www.itu.int/pub/T-SP-E.212B-2013
> + * - http://en.wikipedia.org/wiki/Mobile_Network_Code

How are we dealing with the contents of these two tables? Union part?

I noticed MCC 374, 724, 502, 330 has both two and three-digit MNC. I think we should take care of them all in this bug. Please help complete the table, thanks.

Comment 9

[shawn ku [:sku]]

(In reply to Hsin-Yi Tsai (OOO 5/30 ~ 6/8) [:hsinyi] from comment #8)
> Comment on attachment 8430515 [details] [diff] [review]
> Bug 1014408 - B2G RIL: show empty APN for 405-05 SIM. v2.
> 
> Review of attachment 8430515 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/ril_consts.js
> @@ +2975,5 @@
> > + * The table for MCC/MNC which the length of MNC is 3.
> > + *
> > + * This table is built from below links.
> > + * - http://www.itu.int/pub/T-SP-E.212B-2013
> > + * - http://en.wikipedia.org/wiki/Mobile_Network_Code
> 
> How are we dealing with the contents of these two tables? Union part?

Yes, union.

> 
> I noticed MCC 374, 724, 502, 330 has both two and three-digit MNC. I think
> we should take care of them all in this bug. Please help complete the table,
> thanks.

Sure, will address this in next patch. Thanks!!

Comment 10

[shawn ku [:sku]]

Attachment: Bug 1014408 - B2G RIL: show empty APN for 405-05 SIM. v3.

Comment 11

[shawn ku [:sku]]

Attachment: Bug 1014408 - B2G RIL: show empty APN for 405-05 SIM. v3.

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8430645 [details] [diff] [review]
Bug 1014408 - B2G RIL: show empty APN for 405-05 SIM. v3.

Review of attachment 8430645 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, r=me with comment addressed.

::: dom/system/gonk/ril_consts.js
@@ +2989,5 @@
> +    ["130", // Digicel Trinidad and Tobago Ltd.
> +     "140"  // LaqTel Ltd.
> +    ],
> +  // India.
> +  "405":

Per T-SP-E.212B-2013, there's also MNC 000.

Comment 13

[shawn ku [:sku]]

Attachment: Bug 1014408 - B2G RIL: show empty APN for 405-05 SIM. v3. r=HsinYi.

Comment 14

[shawn ku [:sku]]

try is green - https://tbpl.mozilla.org/?tree=Try&rev=c2614d8f69e7

Comment 15

[Kai-Zhen Li [:seinlin][:kli]]

AIK, On tarako, there is a work around in gaia apn list to display the APN correctly for some special case. I think v1.3t should pick this patch to solve the APN isse with the right solution.

Comment 16

[(PTO May 7-12) Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/bcd7938e4d69

Comment 17

[(PTO May 7-12) Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bcd7938e4d69

Comment 18

[Joe Cheng [:jcheng] (please needinfo)]

if this is not blocking any partner release, let's limit our change to 1.3T

Comment 19

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to Joe Cheng [:jcheng] from comment #18)
> if this is not blocking any partner release, let's limit our change to 1.3T

Joe, if this can be landed in 1.3t, partner do not need to do some work around in gaia to display APN correctly. Work around is done case by case, but this can fix similar issues by one patch.