Closed
Bug 1014440
Opened 10 years ago
Closed 9 years ago
[Settings] refactor Firefox Accounts panel with AMD pattern
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: scottwu)
References
Details
Attachments
(1 file)
Overview Description: Refactor Firefox Accounts panel with AMD pattern referring to https://github.com/gasolin/gaia/tree/master/apps/settings to make it modularize and more easier to maintain Expected Results: pass all settings test and act the same as original implementation Additional Information:
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → scwwu
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8692723 [details] [review] [gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master Hi Fred, I've refactored the Firefox Account panel using AMD pattern. Could you review it for me? Thanks!
Attachment #8692723 -
Flags: review?(gasolin)
Reporter | ||
Comment 3•9 years ago
|
||
Please also set review to https://github.com/6a68 who is most familar with fxa panel now...
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8692723 [details] [review] [gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master Hello Jared, I just refactored the panel for Firefox Accounts in the Settings app with AMD pattern. I kept all the existing functions and unit tests, so everything is expected to work as before. Wonder if you have the time to take a look? Thanks!
Attachment #8692723 -
Flags: review?(6a68)
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8692723 [details] [review] [gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master Thank you for deal with this, Scott! I left some comment on github, please address them and set review again.
Attachment #8692723 -
Flags: review?(gasolin)
Comment 6•9 years ago
|
||
Comment on attachment 8692723 [details] [review] [gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master Hi Scott, Sorry, but I haven't been involved with Gaia for over a year. Looks like you got some feedback on the review, though ^_^ Cheers, Jared
Attachment #8692723 -
Flags: review?(6a68)
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8692723 [details] [review] [gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master Hi Fred, I made changes based on your suggestions. Thanks for taking the time to review!
Attachment #8692723 -
Flags: review?(gasolin)
Reporter | ||
Comment 8•9 years ago
|
||
Comment on attachment 8692723 [details] [review] [gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master LGTM, thanks Scott! Please remove the debug log before the merge
Attachment #8692723 -
Flags: review?(gasolin) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Got it, thanks! It's been merged.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•