1014440 - [Settings] refactor Firefox Accounts panel with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Refactor Firefox Accounts panel with AMD pattern referring to
https://github.com/gasolin/gaia/tree/master/apps/settings

to make it modularize and more easier to maintain


Expected Results:

pass all settings test and act the same as original implementation

Additional Information:

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master

Comment 2

[Scott Wu [:scottwu]]

Comment on attachment 8692723 [details] [review]
[gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master

Hi Fred, I've refactored the Firefox Account panel using AMD pattern. Could you review it for me? Thanks!

Comment 3

[[e-mail]]

Please also set review to https://github.com/6a68 who is most familar with fxa panel now...

Comment 4

[Scott Wu [:scottwu]]

Comment on attachment 8692723 [details] [review]
[gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master

Hello Jared, I just refactored the panel for Firefox Accounts in the Settings app with AMD pattern. 

I kept all the existing functions and unit tests, so everything is expected to work as before. Wonder if you have the time to take a look? Thanks!

Comment 5

[[e-mail]]

Comment on attachment 8692723 [details] [review]
[gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master

Thank you for deal with this, Scott! 
I left some comment on github, please address them and set review again.

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8692723 [details] [review]
[gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master

Hi Scott,

Sorry, but I haven't been involved with Gaia for over a year. Looks like you got some feedback on the review, though ^_^

Cheers,

Jared

Comment 7

[Scott Wu [:scottwu]]

Comment on attachment 8692723 [details] [review]
[gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master

Hi Fred, I made changes based on your suggestions. Thanks for taking the time to review!

Comment 8

[[e-mail]]

Comment on attachment 8692723 [details] [review]
[gaia] scottwu:1014440-firefox-accounts-amd > mozilla-b2g:master

LGTM, thanks Scott!

Please remove the debug log before the merge

Comment 9

[Scott Wu [:scottwu]]

Got it, thanks! It's been merged.