1014460 - Extend the retention period of UITour.seenPageIDs

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Currently, UITour.seenPageIDs is retained for 2 weeks. We're debating whether this is currently long enough to be useful (especially given the fallout of having discovered bug 1012526 so late).

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

We haven't come to a decision whether we need this yet, but a heads up that we possibly may need this in 30. I know it's getting late in the cycle :\ Will be only a really low-risk config change though.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Marco, could you add this to the current iteration? (I need to get couple of possible patches ready in case we decide we need this.)

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1 - 4 weeks

Ok, I figure if do end up needing this, it'll likely end up being one of two options, extending the retention to either:
* 4 weeks (twice existing retention)
* 8 weeks (2 weeks more than one cycle)

This patch makes it 4 weeks.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1 - 8 weeks

And this patch makes it 8 weeks.

Comment 5

[Marco Mucci [:MarcoM]]

Added to Iteration 32.2

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Who is to make the final call here on the duration?  We've got one more desktop Beta to land this to which goes to build on Thursday so this will have to be decided (and whichever patch is to be uplifted nominated) before Thurs am PT or we will not be able to adjust this for FF30.

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Lukas Blakk [:lsblakk] from comment #6)
> Who is to make the final call here on the duration?

That'd be me. I'm still trying to gather more information/opinions from people in awkward timetimes.

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Ok, after talking more with Ilana and Habber, seems the 8 week retention period is our best option.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8428522 [details] [diff] [review]
Patch v1 - 8 weeks

Review of attachment 8428522 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/9c26bf515b44

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8428522 [details] [diff] [review]
Patch v1 - 8 weeks

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 952568, bug 1012526
User impact if declined: No user impact. Impact is lack of usable Telemetry data, affecting analysis of impact of whats-new tour page on usage of UI.
Testing completed (on m-c, etc.): Unit tested
Risk to taking this patch (and alternatives if risky): Very minimal - only changing a hardcoded configuration option (and updating associated test).
String or IDL/UUID changes made by this patch: None

Comment 12

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(Note: Due to the "wonderful" nature of timezones, it's possible I won't be able to land this on Aurora/Beta myself in time, once it gets approval.)

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9c26bf515b44

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3a57158c975c
https://hg.mozilla.org/releases/mozilla-aurora/rev/96f3899ea1c3

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/3a57158c975c