Closed Bug 1014508 Opened 11 years ago Closed 11 years ago

[tarako] Offline detection is broken - Marketplace is always considering we are online

Categories

(Marketplace Graveyard :: General, defect, P1)

Other
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

VERIFIED FIXED
2014-05-27

People

(Reporter: vcarciu, Assigned: mat)

References

Details

(Keywords: regression)

tarako build identifier:20140331101634 connectivity used:Offline noticed on: latest dev app used for test: - steps to reproduce: 1.Be sure that your tarako device is offline 2.Start the MP app expected behavior: User is asked to go online in order to start the app observed behavior: App is opened, no warning displayed reproducible?: yes ashes: behavior seen on regular marketplace using inari/hamachi: yes/no
Keywords: regression
So, I think it's my fault. In https://github.com/mozilla/yogafire/commit/59aee75c212669bdae4f13e8a68c568c872c722e I assumed consumer_info promise would be rejected when we are offline, but that's not the case. So we are always considered online when launching the app. There might be another second bug, because we are supposed to detect offline status after initial launch with checkOnline(), and that never seems to happen.
(In reply to Mathieu Pillard [:mat] from comment #1) > So, I think it's my fault. In > https://github.com/mozilla/yogafire/commit/ > 59aee75c212669bdae4f13e8a68c568c872c722e I assumed consumer_info promise > would be rejected when we are offline, but that's not the case. So we are > always considered online when launching the app. > > There might be another second bug, because we are supposed to detect offline > status after initial launch with checkOnline(), and that never seems to > happen. Yeah , I can confirm that all buttons are enabled while offline(Feedback , Terms of use, Privacy Policy, Report Abuse, Search...). Based on the comment from above, I think that we can keep this bug for both issue, but please let me know if a new bug is needed.
In addition, relying on consumer_info might not be such a good idea, because the API call it makes will be skipped if we can detect a valid region with the SIM.
Assignee: nobody → mpillard
Priority: -- → P1
Target Milestone: --- → 2014-05-27
Severity: normal → blocker
Summary: [tarako] Marketplace can be launched while offline → [tarako] Offline detection is broken - Marketplace is always considering we are online
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Verified as fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.