Closed
Bug 1014508
Opened 11 years ago
Closed 11 years ago
[tarako] Offline detection is broken - Marketplace is always considering we are online
Categories
(Marketplace Graveyard :: General, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-05-27
People
(Reporter: vcarciu, Assigned: mat)
References
Details
(Keywords: regression)
tarako build identifier:20140331101634
connectivity used:Offline
noticed on: latest dev
app used for test: -
steps to reproduce:
1.Be sure that your tarako device is offline
2.Start the MP app
expected behavior:
User is asked to go online in order to start the app
observed behavior:
App is opened, no warning displayed
reproducible?: yes
ashes:
behavior seen on regular marketplace using inari/hamachi: yes/no
Reporter | ||
Updated•11 years ago
|
Keywords: regression
Assignee | ||
Comment 1•11 years ago
|
||
So, I think it's my fault. In https://github.com/mozilla/yogafire/commit/59aee75c212669bdae4f13e8a68c568c872c722e I assumed consumer_info promise would be rejected when we are offline, but that's not the case. So we are always considered online when launching the app.
There might be another second bug, because we are supposed to detect offline status after initial launch with checkOnline(), and that never seems to happen.
Reporter | ||
Comment 2•11 years ago
|
||
(In reply to Mathieu Pillard [:mat] from comment #1)
> So, I think it's my fault. In
> https://github.com/mozilla/yogafire/commit/
> 59aee75c212669bdae4f13e8a68c568c872c722e I assumed consumer_info promise
> would be rejected when we are offline, but that's not the case. So we are
> always considered online when launching the app.
>
> There might be another second bug, because we are supposed to detect offline
> status after initial launch with checkOnline(), and that never seems to
> happen.
Yeah , I can confirm that all buttons are enabled while offline(Feedback , Terms of use, Privacy Policy, Report Abuse, Search...).
Based on the comment from above, I think that we can keep this bug for both issue, but please let me know if a new bug is needed.
Assignee | ||
Comment 3•11 years ago
|
||
In addition, relying on consumer_info might not be such a good idea, because the API call it makes will be skipped if we can detect a valid region with the SIM.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mpillard
Priority: -- → P1
Target Milestone: --- → 2014-05-27
Assignee | ||
Updated•11 years ago
|
Severity: normal → blocker
Summary: [tarako] Marketplace can be launched while offline → [tarako] Offline detection is broken - Marketplace is always considering we are online
Assignee | ||
Comment 4•11 years ago
|
||
Started working on it: https://github.com/mozilla/yogafire/pull/47
Basically, both https://github.com/mozilla/yogafire/commit/59aee75c212669bdae4f13e8a68c568c872c722e and https://github.com/mozilla/yogafire/commit/807a7da8b5a6e0e5f878a584d808773118a3ed65 don't work correctly and will have to be tweaked or reverted.
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•