1014508 - [tarako] Offline detection is broken - Marketplace is always considering we are online

Status: VERIFIED FIXED

(Marketplace Graveyard :: General, defect, P1)

Description

[Victor Carciu]

tarako build identifier:20140331101634
connectivity used:Offline
noticed on: latest dev
app used for test: - 

steps to reproduce:
1.Be sure that your tarako device is offline
2.Start the MP app

expected behavior:
User is asked to go online in order to start the app

observed behavior:
App is opened, no warning displayed

reproducible?: yes

ashes:

behavior seen on regular marketplace using inari/hamachi: yes/no

Comment 1

[Mathieu Pillard [:mat]]

So, I think it's my fault. In https://github.com/mozilla/yogafire/commit/59aee75c212669bdae4f13e8a68c568c872c722e I assumed consumer_info promise would be rejected when we are offline, but that's not the case. So we are always considered online when launching the app.

There might be another second bug, because we are supposed to detect offline status after initial launch with checkOnline(), and that never seems to happen.

Comment 2

[Victor Carciu]

(In reply to Mathieu Pillard [:mat] from comment #1)
> So, I think it's my fault. In
> https://github.com/mozilla/yogafire/commit/
> 59aee75c212669bdae4f13e8a68c568c872c722e I assumed consumer_info promise
> would be rejected when we are offline, but that's not the case. So we are
> always considered online when launching the app.
> 
> There might be another second bug, because we are supposed to detect offline
> status after initial launch with checkOnline(), and that never seems to
> happen.

Yeah , I can confirm that all buttons are enabled while offline(Feedback , Terms of use, Privacy Policy, Report Abuse, Search...).
Based on the comment from above, I think that we can keep this bug for both issue, but please let me know if a new bug is needed.

Comment 3

[Mathieu Pillard [:mat]]

In addition, relying on consumer_info might not be such a good idea, because the API call it makes will be skipped if we can detect a valid region with the SIM.

Comment 4

[Mathieu Pillard [:mat]]

Started working on it: https://github.com/mozilla/yogafire/pull/47

Basically, both https://github.com/mozilla/yogafire/commit/59aee75c212669bdae4f13e8a68c568c872c722e and https://github.com/mozilla/yogafire/commit/807a7da8b5a6e0e5f878a584d808773118a3ed65 don't work correctly and will have to be tweaked or reverted.

Comment 5

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/yogafire/commit/ac32d7171fc8186be75262170fb5e44249b5583b

Comment 6

[Victor Carciu]

Verified as fixed