Closed
Bug 1014587
Opened 10 years ago
Closed 10 years ago
Simplify toolbar-menubar and TabsToolbar styling by never giving them a background color
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 32
People
(Reporter: dao, Assigned: dao)
Details
(Whiteboard: p=2 s=it-32c-31a-30b.3 [qa-])
Attachments
(1 file)
|
4.76 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
We currently set -moz-dialog / @customToolbarColor@ as all toolbar's background color and then remove toolbar-menubar's and TabsToolbar's background in various places. It's far easier if we don't give these two toolbars a background color in the first place, as there's no condition under which they would need one.
Attachment #8427025 -
Flags: review?(mdeboer)
Flags: firefox-backlog+
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8427025 [details] [diff] [review] patch LGTM! Thanks for this simplification :)
Attachment #8427025 -
Flags: review?(mdeboer) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/640f04e26095 Marco, please add this to the current iteration.
Flags: needinfo?(mmucci)
|
||
Comment 3•10 years ago
|
||
Added to Iteration 32.2
Flags: needinfo?(mmucci)
Whiteboard: p=2 → p=2 s=it-32c-31a-30b.2 [qa?]
|
|
||
Updated•10 years ago
|
Whiteboard: p=2 s=it-32c-31a-30b.2 [qa?] → p=2 s=it-32c-31a-30b.3 [qa?]
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/640f04e26095
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
|
||
Updated•10 years ago
|
Whiteboard: p=2 s=it-32c-31a-30b.3 [qa?] → p=2 s=it-32c-31a-30b.3 [qa-]
|
|
||
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•