1014616 - (vertical-homescreen) Align Icon/Divider layout to spec

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Peter La]

Currently the icons are not spaced according to spec.  Divider spacing between divider and icon rows are also off.  Please check both 3 column and 4 column views.

Spec for layout:
https://mozilla.box.com/s/gl2fjrkzlnyylmnlnw13

Comment 1

[Peter La]

Attachment: IconGridLayoutAdjustments-20140527.zip

Hi Kevin,

Attached are some slight tweaks from the original specs to the icon grid layouts.  There are really only 2 things that changed:

1) the vertical distance between icon rows (in 3 column mode, this distance has increased from the original; in 4 column mode, this distance has decreased from the original spec)
2) the vertical padding between the top icon and the rocketbar has decreased

Everything else can remain the same as the original specs.

Please go ahead and layout the icon grid according to this spec and fill in everything else from the original spec.

Let me know if you need clarification.

Thanks!

Comment 2

[Stephany Wilkes]

Just flagging Candice that this is ready for assignment and that VxD specs are done.

Comment 3

[Candice Serran (:cserran)]

Thanks guys...just updated to include so it gets uploaded to our tracking dashboards. Kevin, I assumed this was you since it has to do with grid layout?

Comment 4

[Kevin Grandon :kgrandon]

I might take this, but not actively working on this today (maybe tomorrow). It's on my radar, but please don't assign it to me because someone else may want to take it.

Comment 5

[Kevin Grandon :kgrandon]

Landed a simple patch to align some of these items. I think the dividers still need a bit of work, but I will follow-up with you on this next week: https://github.com/mozilla-b2g/gaia/commit/bf21d38f4ef43ed5b2c88046c1d14e791d07025e

Comment 6

[[e-mail]]

Hi, is this an accident branch to gaia repo? please remove it.

https://github.com/mozilla-b2g/gaia/tree/bug_1014616_vertical_icon_spacing

Comment 7

[Kevin Grandon :kgrandon]

Removed. Thanks.

Comment 8

[Kevin Grandon :kgrandon]

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.