Closed Bug 1014616 Opened 6 years ago Closed 5 years ago

(vertical-homescreen) Align Icon/Divider layout to spec

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86
macOS
defect
Not set

Tracking

(feature-b2g:2.0, b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S3 (6june)
feature-b2g 2.0
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: pla, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Currently the icons are not spaced according to spec.  Divider spacing between divider and icon rows are also off.  Please check both 3 column and 4 column views.

Spec for layout:
https://mozilla.box.com/s/gl2fjrkzlnyylmnlnw13
Hi Kevin,

Attached are some slight tweaks from the original specs to the icon grid layouts.  There are really only 2 things that changed:

1) the vertical distance between icon rows (in 3 column mode, this distance has increased from the original; in 4 column mode, this distance has decreased from the original spec)
2) the vertical padding between the top icon and the rocketbar has decreased

Everything else can remain the same as the original specs.

Please go ahead and layout the icon grid according to this spec and fill in everything else from the original spec.

Let me know if you need clarification.

Thanks!
Just flagging Candice that this is ready for assignment and that VxD specs are done.
Flags: needinfo?(cserran)
Assignee: nobody → kgrandon
feature-b2g: --- → 2.0
Flags: needinfo?(cserran)
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S3 (6june)
Thanks guys...just updated to include so it gets uploaded to our tracking dashboards. Kevin, I assumed this was you since it has to do with grid layout?
Flags: needinfo?(kgrandon)
I might take this, but not actively working on this today (maybe tomorrow). It's on my radar, but please don't assign it to me because someone else may want to take it.
Assignee: kgrandon → nobody
Flags: needinfo?(kgrandon)
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Landed a simple patch to align some of these items. I think the dividers still need a bit of work, but I will follow-up with you on this next week: https://github.com/mozilla-b2g/gaia/commit/bf21d38f4ef43ed5b2c88046c1d14e791d07025e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Hi, is this an accident branch to gaia repo? please remove it.

https://github.com/mozilla-b2g/gaia/tree/bug_1014616_vertical_icon_spacing
Flags: needinfo?(kgrandon)
Removed. Thanks.
Flags: needinfo?(kgrandon)
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
You need to log in before you can comment on or make changes to this bug.