1014698 - Unable to see the keyboard focus indicator on the category list of in-content preferences

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Cycling through Tab to get focus on the category list, it is impossible to know when focus is on that list. However, when it is on the list, pressing up and down will cycle through the categories.

We need to make keyboard focus be more obvious for the category list.

Comment 1

[Hernán Rodriguez Colmeiro (:peregrino)]

I was looking at this one last night, and got to a point where I could apply styles to the category list for when it's focused.
But then another problem appeared: when clicking on a category with the mouse, the :-moz-focusring styles stay applied until you click somewhere else and move the focus away.

Do anyone have a suggestion to fix that?

Comment 2

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: WIP patch

This is a work in progress, it has the problems mentioned in my earlier comment

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Hernán Rodriguez Colmeiro (:peregrino) from comment #1)
> I was looking at this one last night, and got to a point where I could apply
> styles to the category list for when it's focused.
> But then another problem appeared: when clicking on a category with the
> mouse, the :-moz-focusring styles stay applied until you click somewhere
> else and move the focus away.
> 
> Do anyone have a suggestion to fix that?

You could add keydown and mousedown listeners that toggle an attribute to show the focus indicators:

categories.addEventListener("keydown", function() {
  this.setAttribute("keyboard-navigation", "true");
});
categories.addEventListener("mousedown", function() {
  this.removeAttribute("keyboard-navigation");
});

Then in the CSS,

#categories[keyboard-navigation="true"]:-moz-focusring > .category[current] {
  border-top: 1px #ffffff dotted;
  border-bottom: 1px #ffffff dotted;
}

Comment 4

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: bug-1014698.diff

Updated patch. This one fixes the problem.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8433551 [details] [diff] [review]
bug-1014698.diff

Review of attachment 8433551 [details] [diff] [review]:
-----------------------------------------------------------------

Looks and works good. Thanks!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Do you happen to have a Try link handy by chance? :)

Comment 7

[Hernán Rodriguez Colmeiro (:peregrino)]

Uhm. I used to have L1 commit access on this email account but I think got deactivated by a prolonged inactivity I had. Is there a chance to reactivate it so I can push to try?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Hernán Rodriguez Colmeiro (:peregrino) from comment #7)
> Uhm. I used to have L1 commit access on this email account but I think got
> deactivated by a prolonged inactivity I had. Is there a chance to reactivate
> it so I can push to try?

Please file a new bug like https://bugzilla.mozilla.org/show_bug.cgi?id=664170 to request reactivation of your level 1 privleges.

Comment 9

[Hernán Rodriguez Colmeiro (:peregrino)]

I just saw that this happened before and the threshold of inactivity is 3months. I won't bother people to reactivate my L1 until I'm sure I'll be able to not let it expire again ;)

Comment 10

[:Gijs (he/him)]

Attachment: Unable to see the keyboard focus indicator on the category list of in-content preferences,

Unbitrotting

Comment 11

[:Gijs (he/him)]

Ugh, sorry.

/me slaps bzexport

Comment 12

[:Gijs (he/him)]

remote:   https://tbpl.mozilla.org/?tree=Try&rev=c9c62b6bb5ef

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/358904c14a9c

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/358904c14a9c

Comment 15

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 8.1 64bit using latest Nightly 34.0a1 (buildID: 20140729030202).