1015000 - [Vertical Homescreen] Trying to stop a flywheel scrolling start an application

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Build Information
Gaia      ef66efa34ed8a559c8998bde688fae88eb943a7a
Gecko     https://hg.mozilla.org/mozilla-central/rev/b40296602083
BuildID   20140522040230
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

Step to reproduce
With 3 column layout with more than 30 icons (eng build for instance), flick down twice to start flywheel scrolling
Immediately (before the end of scrolling), tap the screen where an icon is (as to stop the flywheel move)

Actual result
Tapping stop the scrolling but also launch the app.

Expected result
As when browsing a list (like Cities when choosing your timezone), tapping the screen should only stop the flywheel scrolling action.

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

The patch works fine although I am wondering if it should be done by Gecko for free

Comment 2

[Kevin Grandon :kgrandon]

Sounds like thus his an APZ issue. I am fine with landing a workaround, but we should file a bug and document it in the code.

Kats - are you aware if any existing APZ bug that may cover this? Thanks!

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8427685 [details]
Github pull request

Giving an early R+ here assuming we have a bug, or file one, for an APZ fix.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Assuming that by "tap" you mean put your finger and then lift it back up, I think this is expected behaviour. If you want to stop a scroll, you have to put your finger down and leave it there. Tapping during a scroll sends a click event in Firefox for Android as well.

Comment 5

[Kevin Grandon :kgrandon]

Ok, thanks for the info kats! I don't think that will work too well for our case as our icon grid is full of icons, so if you hold your finger, you go into edit mode. I don't really think that this is a bug in the first place, but I don't mind Cristians patch either. Let's take it for now.

Comment 6

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/084aee271332178c455d64f7554da28124c2b0c5

Comment 7

[Johan Lorenzo [:jlorenzo]]

I am not able to stop flywheel scrolling with today's new base image (v10H-4) and today's gaia+gecko.

Gaia      12af93123c5db55212d51fe235d39f21209a1eaa
Gecko     https://hg.mozilla.org/mozilla-central/rev/9305a8ec77fe
BuildID   20140609040203
Version   32.0a1
ro.build.version.incremental=104
ro.build.date=Fri Jun  6 17:35:09 CST 2014

Comment 8

[Johan Lorenzo [:jlorenzo]]

Let's create a new regression bug.

Comment 9

[Johan Lorenzo [:jlorenzo]]

See bug 1022956 for regression.

Comment 10

[Kevin Grandon :kgrandon]

2.0 contains this commit.

Comment 11

[Johan Lorenzo [:jlorenzo]]

https://moztrap.mozilla.org/manage/case/13747/