1015015 - HomePanel uninstall isn't robust

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Richard Newman [:rnewman]]

05-22 19:51:33.314 D/HomePanelsManager(15452): HomePanels:Uninstall
Got this while uninstalling an add-on that had failed to add itself to the home screen.


05-22 19:51:33.324 E/HomePanelsManager(15452): Failed to handle event HomePanels:Uninstall
05-22 19:51:33.324 E/HomePanelsManager(15452): org.json.JSONException: No value for id
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.json.JSONObject.get(JSONObject.java:354)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.json.JSONObject.getString(JSONObject.java:510)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.home.HomePanelsManager.handleMessage(HomePanelsManager.java:115)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:205)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:174)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2311)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:356)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:176)

Comment 1

[:Margaret Leibovic]

Isn't this actually fine? If the panel isn't installed, there's nothing to do to uninstall it, and it looks like we're just logging the error.

Maybe to improve this we should just check to see if the panel is installed, and log a more specific error message if it's not.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.