Open Bug 1015015 Opened 6 years ago Updated 6 years ago

HomePanel uninstall isn't robust

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set

Tracking

()

People

(Reporter: rnewman, Unassigned)

References

(Blocks 1 open bug)

Details

05-22 19:51:33.314 D/HomePanelsManager(15452): HomePanels:Uninstall
Got this while uninstalling an add-on that had failed to add itself to the home screen.


05-22 19:51:33.324 E/HomePanelsManager(15452): Failed to handle event HomePanels:Uninstall
05-22 19:51:33.324 E/HomePanelsManager(15452): org.json.JSONException: No value for id
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.json.JSONObject.get(JSONObject.java:354)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.json.JSONObject.getString(JSONObject.java:510)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.home.HomePanelsManager.handleMessage(HomePanelsManager.java:115)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:205)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:174)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2311)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:356)
05-22 19:51:33.324 E/HomePanelsManager(15452): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:176)
Isn't this actually fine? If the panel isn't installed, there's nothing to do to uninstall it, and it looks like we're just logging the error.

Maybe to improve this we should just check to see if the panel is installed, and log a more specific error message if it's not.
Blocks: lists
You need to log in before you can comment on or make changes to this bug.