1015097 - Rewrite test_outgoing_emergency_in_airplane_mode.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

I got some problem when running this test case. For example, I tried to run this case repeatedly for about 10 times on local machine. Usually, 2 ~ 4 of them are failed......

So, I would like to rewrite it by promise and utility in head.js. From my experimental results, it works well on local machine.

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Rewrite test_outgoing_emergency_in_airplane_mode.js

Comment 2

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 8427647 [details] [diff] [review]
Rewrite test_outgoing_emergency_in_airplane_mode.js

Review of attachment 8427647 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet!

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Rewrite test_outgoing_emergency_in_airplane_mode.js. r=hsinyi

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=ab5b1f0265d3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f107c585cbc0

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f107c585cbc0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Is there any reason this wouldn't work on v1.4 as well? We can uplift it a=test-only if so :)

Comment 8

[Szu-Yu Chen [:aknow] (inactive)]

We have to modify another file as well, so the patch could work on v1.4.

However, from the latest results, https://bugzilla.mozilla.org/show_bug.cgi?id=909485#c98 , it seems that the issue still happens. So there might be no benefit to uplift the patch.

Sad... I'll keep working on it and try to find the root cause.