1015113 - [Flame] Build bootloader

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[:gerard-majax]

The Flame's bootloader can be built from source, and it seems to be producing a working bootloader.

> $ fastboot oem mem
> ...
> (bootloader) 	Usage: fastboot oem mem capacity
> (bootloader) 	capcity should between 128 and 1024, 0 for auto detection
> FAILED (remote: unknown reason)
> finished. total time: 0.003s

This way I could hack the bootloader and make it able to set memory to 128M.

The remote to use is git://github.com/t2m-foxfone/kernel_lk, branch foxfone-one. It should be checked out in bootable/bootloader/lk. Then setting TARGET_NO_BOOTLOADER to false, it gets built.

Comment 1

[:gerard-majax]

Michael, should we fork their kernel_lk repo on our side ?

Comment 2

[Michael Wu [:mwu]]

Sure, if you think we'll want to make our own local changes.

Comment 3

[:gerard-majax]

(In reply to Michael Wu [:mwu] from comment #2)
> Sure, if you think we'll want to make our own local changes.

Well we can already fix the fastboot oem mem command, I do have it locally. However, I cannot fork in the mozilla-b2g account.

Comment 4

[:gerard-majax]

Attachment: Manifest update

Please find attached a link to the github pull request that adds the new project in the manifest.

Comment 5

[:gerard-majax]

Attachment: Device update

Please find attached a link to the github pull request that triggers the building of the bootloader.

Comment 6

[Michael Wu [:mwu]]

Comment on attachment 8430038 [details] [review]
Device update

I think we can just remove this line altogether. See if you can do that. If not, this is fine.

Comment 7

[Michael Wu [:mwu]]

Comment on attachment 8430035 [details] [review]
Manifest update

Make sure this repo is mirrored to git.mozilla.org before merging. We may also need releng to add support for a new remote, since they replace all remotes with remotes pointing to git.mozilla.org mirrors.

Comment 8

[:gerard-majax]

(In reply to Michael Wu [:mwu] from comment #7)
> Comment on attachment 8430035 [details] [review]
> Manifest update
> 
> Make sure this repo is mirrored to git.mozilla.org before merging. We may
> also need releng to add support for a new remote, since they replace all
> remotes with remotes pointing to git.mozilla.org mirrors.

Michael, I've updated the references in my PR to match the new repos. Are we good to go or do we need bits from releng?

Comment 9

[Michael Wu [:mwu]]

You should be good to go.

Comment 10

[:gerard-majax]

Manifest part: https://github.com/mozilla-b2g/b2g-manifest/commit/3327c4330935e9eeb9b9a390c117f62d6b0193d0

Comment 11

[:gerard-majax]

Attachment: KK Device update: building bootloader

Michael, I finally found some time to fix the remaining bit that was blocking landing the building of the bootloader. Mainly, we need a version.inc file that contains the bootloader version.

I've hacked the extract-files.sh script to pull it at the same time than blobs.

So far, after building, this seems to be okay:

> alex@portable-alex:~/codaz/Mozilla/b2g/devices/Flame/B2G.KK$ ls out/target/product/flame/emmc_appsboot.mbn
> -rw-r--r-- 1 alex alex 273K sept.  2 11:06 out/target/product/flame/emmc_appsboot.mbn
> alex@portable-alex:~/codaz/Mozilla/b2g/devices/Flame/B2G.KK$ ls ../images/v166/emmc_appsboot.mbn 
> -rw-r--r-- 1 alex alex 273K août  28 17:04 ../images/v166/emmc_appsboot.mbn
> alex@portable-alex:~/codaz/Mozilla/b2g/devices/Flame/B2G.KK$ md5sum ../images/v166/emmc_appsboot.mbn 
> e2bcbb84cba12d890fe44c2050c58a37  ../images/v166/emmc_appsboot.mbn
> alex@portable-alex:~/codaz/Mozilla/b2g/devices/Flame/B2G.KK$ md5sum out/target/product/flame/emmc_appsboot.mbn
> e2bcbb84cba12d890fe44c2050c58a37  out/target/product/flame/emmc_appsboot.mbn

I get the very same md5 for the rebuilt bootloader compared to the one from the v166 base image.

How do we coordinate for updating the backup-flame directory to avoid breaking builds for pvtbuilds?

Comment 12

[:gerard-majax]

Michael, do you have some time to review this?

Comment 13

[Michael Wu [:mwu]]

Comment on attachment 8482615 [details] [review]
KK Device update: building bootloader

Review comments on PR.

Comment 14

[:gerard-majax]

Thanks. I've replied there, but I'm unsure for the bootloader version: I noticed this was reflecting/linked to the baseimage version, so is hardcoding it such a good idea?

Comment 15

[Michael Wu [:mwu]]

If it's being updated with every base image update, then it's not really useful. Maybe we can disable reporting the bootloader version when doing our own builds? I'm guessing this might be used for FOTA updates, but those aren't particularly meaningful if you've reflashed everything yourself.

Comment 16

[:gerard-majax]

(In reply to Michael Wu [:mwu] from comment #15)
> If it's being updated with every base image update, then it's not really
> useful. Maybe we can disable reporting the bootloader version when doing our
> own builds? I'm guessing this might be used for FOTA updates, but those
> aren't particularly meaningful if you've reflashed everything yourself.

We can do this, yes.

Comment 17

[:gerard-majax]

Comment on attachment 8482615 [details] [review]
KK Device update: building bootloader

Just switching on the bootloader building.

Comment 18

[:gerard-majax]

Attachment: Disabling version.inc inclusion on JB branch

Comment 19

[:gerard-majax]

Attachment: Disabling version.inc inclusion on KK branch

Comment 20

[:gerard-majax]

Attachment: JB Device update: building bootloader

Comment 21

[:gerard-majax]

Michael, this should match your review:
 - we stop including the version.inc when building the bootloader
 - we just turn off bootloader build disabling

The kernel_lk patches must be merged BEFORE the device update ones.

Comment 22

[Michael Wu [:mwu]]

Comment on attachment 8489000 [details] [review]
JB Device update: building bootloader

Everything looks good, thanks!

Comment 23

[:gerard-majax]

kernel_lk jb: https://github.com/mozilla-b2g/kernel_lk/commit/6f00133ac0f47e90027bd7e263a16b405bfac503
kernel_lk kk: https://github.com/mozilla-b2g/kernel_lk/commit/fda40423ffa573dc6cafd3780515010cb2a086be

Comment 24

[:gerard-majax]

device jb: https://github.com/mozilla-b2g/device-flame/commit/eab9ed2db026c9a2c7943f3bfac350255fa46691
device kk: https://github.com/mozilla-b2g/device-flame/commit/6f72b9d7a2322043fd0c4ba889ad689b084081c5

Comment 25

[:gerard-majax]

Looks like everything is okay now for this bug.