Closed
Bug 1015145
Opened 12 years ago
Closed 12 years ago
Use a magic number to identify crashes related to any stack traversal during bailouts.
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: nbp, Assigned: nbp)
Details
Attachments
(1 file)
|
3.30 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8427695 -
Flags: review?(jdemooij)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8427695 [details] [diff] [review]
Use magic constant when the jitTop is invalided within a bailout.
Review of attachment 8427695 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jit/Bailouts.cpp
@@ +68,5 @@
> }
> }
>
> +// This address is a magic number made to cause crashes while inditcating that
> +// we are making an attempt at marking the stack during a bailout.
Nit: typo, "indicating" and s/at marking/to mark
Attachment #8427695 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a903e95a2018
https://hg.mozilla.org/mozilla-central/rev/a3f2754fcfb8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•