1015147 - Put the user-agent style sheets svg.css and mathml.css in the style sheet cache

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jonathan Watt [:jwatt]]

The user-agent style sheets svg.css and mathml.css should be in the style sheet cache. I don't believe there's any reason to be creating a new instance of these style sheets for each document that needs them.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

This builds on the patch in bug 1014891.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Ah, so svg.css used to be loaded at startup anyway as part of ua.css, right?

Comment 4

[Jonathan Watt [:jwatt]]

Back in 2005, yeah, but bug 287389 changed that.

So my reason for here loading it up front in the cache is that all our products load SVG during startup (like HTML and XUL), so we should cache the SVG sheet (like for HTML and XUL).

Comment 5

[Boris Zbarsky [:bzbarsky]]

Oh, I see.

Yeah, ok.  svg.css is pretty small anyway...

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: patch

Rotted myself with changes to the patch in bug 1014891 - updating for that.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8427943 [details] [diff] [review]
patch

Why not just:

  if (mOnDemandBuiltInUASheets.Contains(aSheet)) {
    return;
  }

instead of reinventing it?

And also, just early return if !aSheet instead of adding null to the list.

>-    mOnDemandBuiltInUASheets.SizeOfExcludingThis(SizeOfStyleSheetsElementIncludingThis,

We should just pass null for the callback, no?  We still want to measure the array memory.

r=me

Comment 8

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f11fd47e89a7

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f11fd47e89a7