1015178 - B2G reftests don't killAndGetStack on timeout

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Andrew Halberstadt [:ahal]]

We implemented kill and get stack for B2G in mozrunner, but reftests still use b2gautomation.py. Ideally we'd move them off b2gautomation.py and onto mozrunner, but the simple thing to do here is to just re-implement it.

http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/remote.py#246

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: kill and get stack for b2g reftest

Should be all that's needed. Try run with the patch from bug 966646 to help reproduce timeouts: https://tbpl.mozilla.org/?tree=Try&rev=cfee277e40ae

Comment 2

[Andrew Halberstadt [:ahal]]

So that somewhat worked, after the timeout the process was killed and checkForCrashes invoked.. but minidump_stackwalk failed with "header signature mismatch":
https://tbpl.mozilla.org/php/getParsedLog.php?id=40287378&tree=Try&full=1#error1

Ted, what does it mean when this happens?

Comment 3

[(not currently active) Ted Mielczarek]

We chatted on IRC, the current working theory is that maybe we're pulling the dump from the device too soon and it's not finished writing yet. ahal is going to try putting a sleep in there to test that theory.

Comment 4

[Andrew Halberstadt [:ahal]]

Try run with sleep:
https://tbpl.mozilla.org/?tree=Try&rev=d90894750c8e

If this works, I'll modify it to poll the b2g process before committing.

Comment 5

[Andrew Halberstadt [:ahal]]

I think that worked:
https://tbpl.mozilla.org/php/getParsedLog.php?id=40481364&tree=Try&full=1#error0

I'll get a patch up shortly.

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: b2g_kill_and_get_stack

Updated patch to wait for b2g process to stop existing.

New try run just to be sure it still works:
https://tbpl.mozilla.org/?tree=Try&rev=50e86a011121

Comment 7

[William Lachance (:wlach) (use needinfo!)]

Comment on attachment 8429567 [details] [diff] [review]
b2g_kill_and_get_stack

Review of attachment 8429567 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me, one minor suggestion.

::: build/mobile/b2gautomation.py
@@ +155,5 @@
>                                self.lastTestSeen, int(timeout))
> +                self._devicemanager.killProcess('/system/b2g/b2g', sig=signal.SIGABRT)
> +
> +                timeout = 10 # seconds
> +                for i in range(0, timeout):

I think the marionette approach is somewhat more intuitive:

starttime = datetime.datetime.now()
while datetime.datetime.now() - starttime < datetime.timedelta(seconds=timeout):

Comment 8

[(not currently active) Ted Mielczarek]

(In reply to Andrew Halberstadt [:ahal] from comment #5)
> I think that worked:
> https://tbpl.mozilla.org/php/getParsedLog.
> php?id=40481364&tree=Try&full=1#error0

Yeah, that looks good. Good call!

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: b2g_kill_and_get_stack

Updated patch with suggestion. Carry r+ forward.

Comment 10

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/b2g-inbound/rev/33a2a8aaed24

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/33a2a8aaed24