1015294 - [Homescreen] Update to use gaia-header

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Initial patch. Need confirmation from visual on header color/theme.

Comment 2

[Wilson Page [:wilsonpage]]

Attachment: verticalhome-edit-header.png

Screen-shot added for visual review.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8471066 [details]
verticalhome-edit-header.png

Peter - could you give this a visual review? The color of the header is changing a bit here. Thanks!

Comment 4

[Peter La]

Hey Kevin,

I'm going to needinfo Przemek here who is working on Frameworks.  He'll provide the final color spec.

Comment 5

[Przemek Abratowski [:przemek] UX]

Attachment: EditModeColorSpec.jpg

The homescreen edit header color should be #333333. That is the same color as this screens overall background. This is intended to create a more seamless view. Spec attached.

Note: since we are using one dark header for dark apps, the media, home edit and home collections screens will all use the #333333 header color. That means we'll have to adjust the background in the media apps if we want to create the same seamless feel throughout, I believe this is being done with Bug 1050404.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8469420 [details] [review]
pull-request (master)

Hey Wilson - need to make a few changes here before we can land this. we need to lazy load the header logic because it's not used onload, you can do so here: https://github.com/mozilla-b2g/gaia/blob/master/apps/verticalhome/js/app.js#L105

You should also remove the old logic if it's no longer needed. Is headers.css/font_size_utils.js still needed?

Please make updates and flag me again, or if you're slammed you can assign to me and I'll take a look.

Comment 7

[Wilson Page [:wilsonpage]]

Attachment: fl-app-updated-theme.png

Comment 8

[Wilson Page [:wilsonpage]]

Attachment: verticalhome-updated-theme.png

Comment 9

[Wilson Page [:wilsonpage]]

Comment on attachment 8469420 [details] [review]
pull-request (master)

UPDATED

- Lazy-load scripts added
- Updated gaia-theme to v0.2.1
- Curtain now uses dynamic theme --background color
- Updated fl app that also depends on gaia-theme (screen-shot attached)

Comment 10

[Przemek Abratowski [:przemek] UX]

Comment on attachment 8472293 [details]
verticalhome-updated-theme.png

This screen looks good, thanks.

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8469420 [details] [review]
pull-request (master)

Closer! But we now have a few failing marionette tests. Can you ensure the tests are working then flag me for review again? Thanks!

Comment 12

[Wilson Page [:wilsonpage]]

Comment on attachment 8469420 [details] [review]
pull-request (master)

Looks like we're just getting a keyboard intermittent in gaia-try now. I've restarted a few times with no luck.

Comment 13

[Kevin Grandon :kgrandon]

Comment on attachment 8469420 [details] [review]
pull-request (master)

Seems fine, test is a bit sketchy cause we don't see it failing in master. Might want to either rebase or watch the tree after landing.

Comment 14

[Wilson Page [:wilsonpage]]

Comment on attachment 8469420 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/e418b8cf30982a66bbcbb03846ecade68a8bc2d6