1015300 - [WAPPush] Update to use gaia-header

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Wappush, defect)

Comment 1

[Yan Or]

Attachment: Pull request

Kevin,

Please redirect r? as needed.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8429811 [details] [review]
Pull request

Hey, you should probably use the modules page (https://wiki.mozilla.org/Modules/FirefoxOS) to find the right reviewer, or use the history in github of the repo. In this case, I think it would make sense for Gabrielle to review this perhaps.

Gabrielle - could you please take a look at this? If you don't have time, feel free to delegate to me. Thanks!

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: Screenshot w/o the patch

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: Screenshot with the patch

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: Patch used for desktop testing

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8429811 [details] [review]
Pull request

I've tested with this patch applied but the result is somewhat bizarre: the close button appears minuscule and with the looks of a system button and both the "Accept" button and the title appear in the wrong place.

I've attached a patch (attachment 8431435 [details] [diff] [review]) that you can apply on top of your changes and that makes the wappush app visible in the homescreen and adds a button that allows you to send a test message (click on the notification for the message to be displayed). You'll need to remove your profile directory after applying this patch for the new manifest to be used.

I've also attached two screenshot with and without your changes.

Comment 7

[Yan Or]

Comment on attachment 8429811 [details] [review]
Pull request

Gabriele, the platform bug which caused the problem you saw has been fixed.  I've always rebased off the latest master.  Please review now.  Thanks.

Comment 8

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8429811 [details] [review]
Pull request

LGTM, but is there really no other way to hide the Accept button than using !important? It feels... wrong :-/

Comment 9

[Yan Or]

Yeah, I know.  Unfortunately without "host" and "content" selectors support in shadow dom, this is the only way for now.  We are working with platform team to add those support so hopefully we can remove this in a future release.

Comment 10

[Wilson Page [:wilsonpage]]

Comment on attachment 8429811 [details] [review]
Pull request

LANDED on 'master' https://github.com/mozilla-b2g/gaia/commit/20cb0fb9064a749375482a817c0c1c8a6cc08ee7

Comment 11

[ankit93040]

Hi Wilson

Please uplift these to v2.0 as well.

Thanks

Comment 12

[Wilson Page [:wilsonpage]]

Gaia-header is a v2.1 addition and is not intended for v2.0.