Closed
Bug 1015300
Opened 11 years ago
Closed 10 years ago
[WAPPush] Update to use gaia-header
Categories
(Firefox OS Graveyard :: Gaia::Wappush, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yor, Assigned: yor)
References
Details
Attachments
(4 files)
No description provided.
Blocks: gaia-header
Kevin, Please redirect r? as needed.
Attachment #8429811 -
Flags: review?(kgrandon)
Comment 2•10 years ago
|
||
Comment on attachment 8429811 [details] [review] Pull request Hey, you should probably use the modules page (https://wiki.mozilla.org/Modules/FirefoxOS) to find the right reviewer, or use the history in github of the repo. In this case, I think it would make sense for Gabrielle to review this perhaps. Gabrielle - could you please take a look at this? If you don't have time, feel free to delegate to me. Thanks!
Attachment #8429811 -
Flags: review?(kgrandon) → review?(gsvelto)
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8429811 [details] [review] Pull request I've tested with this patch applied but the result is somewhat bizarre: the close button appears minuscule and with the looks of a system button and both the "Accept" button and the title appear in the wrong place. I've attached a patch (attachment 8431435 [details] [diff] [review]) that you can apply on top of your changes and that makes the wappush app visible in the homescreen and adds a button that allows you to send a test message (click on the notification for the message to be displayed). You'll need to remove your profile directory after applying this patch for the new manifest to be used. I've also attached two screenshot with and without your changes.
Attachment #8429811 -
Flags: review?(gsvelto) → review-
Comment on attachment 8429811 [details] [review] Pull request Gabriele, the platform bug which caused the problem you saw has been fixed. I've always rebased off the latest master. Please review now. Thanks.
Attachment #8429811 -
Flags: review- → review?(gsvelto)
Comment 8•10 years ago
|
||
Comment on attachment 8429811 [details] [review] Pull request LGTM, but is there really no other way to hide the Accept button than using !important? It feels... wrong :-/
Attachment #8429811 -
Flags: review?(gsvelto) → review+
Yeah, I know. Unfortunately without "host" and "content" selectors support in shadow dom, this is the only way for now. We are working with platform team to add those support so hopefully we can remove this in a future release.
Comment 10•10 years ago
|
||
Comment on attachment 8429811 [details] [review] Pull request LANDED on 'master' https://github.com/mozilla-b2g/gaia/commit/20cb0fb9064a749375482a817c0c1c8a6cc08ee7
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 11•10 years ago
|
||
Hi Wilson Please uplift these to v2.0 as well. Thanks
Flags: needinfo?(wilsonpage)
Comment 12•10 years ago
|
||
Gaia-header is a v2.1 addition and is not intended for v2.0.
Flags: needinfo?(wilsonpage)
You need to log in
before you can comment on or make changes to this bug.
Description
•