Closed Bug 1015448 Opened 10 years ago Closed 10 years ago

[Wallpaper] - Fix wall paper file types and sizes

Categories

(Firefox OS Graveyard :: Gaia::Wallpaper, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S3 (6june)

People

(Reporter: pdahiya, Assigned: pdahiya)

Details

Attachments

(1 file)

As identified in  https://bugzilla.mozilla.org/show_bug.cgi?id=1011460#c22

There are issues with the wallpaper files 

1) The FX_*.jpg files are actually pngs, not jpegs, so they should at least have their filenames changed.  Since they are line art they might not look right as jpegs. If visdev allows us to convert them we should just make them jpegs. If not, they should be renamed to match their actual file type.

2) Some or all of the Illus_* wallpapers are square rather than rectangular, so we're probably using about 50% more memory on displaying those than we need to. These should be cropped to match the actual form factors that we are targeting.  We'll probably want visdev to do the cropping to decide where to cut the pattern.  (Note that these are also line art, not photos, but are real jpegs, not pngs).
 https://bugzilla.mozilla.org/show_bug.cgi?id=1011460#c28

Carrying over Patryk's comment:

Resized illustrated wallpapers, I also ran a JPG compressor on them:
https://mozilla.box.com/s/ue0x8qq76seen8bfi83g

For the FX_ set,please rename them to .PNG, because they have low colours they should be smaller as PNGs.
(In reply to Punam Dahiya from comment #1)
>  https://bugzilla.mozilla.org/show_bug.cgi?id=1011460#c28
> 
> Carrying over Patryk's comment:
> 
> Resized illustrated wallpapers, I also ran a JPG compressor on them:
> https://mozilla.box.com/s/ue0x8qq76seen8bfi83g
> 
> For the FX_ set,please rename them to .PNG, because they have low colours
> they should be smaller as PNGs.

Hi Patryk, 
I noticed the wallpaper provided by you have different file names and file paths. 

Here's link to wallpapers inside gaia-master 
https://github.com/mozilla-b2g/gaia/tree/master/apps/wallpaper/resources 

It will help if you can provide a resource folder with same naming convention. 

Or please feel free to take this bug and land wallpaper directly in master. 

Thanks
Punam
Flags: needinfo?(padamczyk)
Ok here you go:
https://mozilla.box.com/s/bp3zgg7dlv0s6u4w49su
Flags: needinfo?(padamczyk)
Assignee: nobody → pdahiya
(In reply to Patryk Adamczyk [:patryk] UX from comment #3)
> Ok here you go:
> https://mozilla.box.com/s/bp3zgg7dlv0s6u4w49su

Thanks Patryk, attached wallpaper looks good. I have noticed @2.25x wallpaper sizes has increased by ~100KB. Is that expected?
Flags: needinfo?(padamczyk)
Looked at the wrong file, please ignore
Flags: needinfo?(padamczyk)
(In reply to Punam Dahiya from comment #1)
>  https://bugzilla.mozilla.org/show_bug.cgi?id=1011460#c28
> 
> Carrying over Patryk's comment:
> 
> Resized illustrated wallpapers, I also ran a JPG compressor on them:
> https://mozilla.box.com/s/ue0x8qq76seen8bfi83g
> 
> For the FX_ set,please rename them to .PNG, because they have low colours
> they should be smaller as PNGs.

Hi Patryk, 
For FX_ set, @F1.5x images are of document type JPEG and the rest are of document type PNG. If we are going to rename to .png , please provide FX_***@F1.5x of document type PNG. Thanks
Flags: needinfo?(padamczyk)
Here you go:
https://mozilla.box.com/s/m26l5btxk5oasj83337r

I changed them to JPG as they were smaller.
Flags: needinfo?(padamczyk) → needinfo?(pdahiya)
Thanks Patryk, I have created patch with updated wallpapers. Please review
Attachment #8430928 - Flags: review?(padamczyk)
Flags: needinfo?(pdahiya)
Attachment #8430928 - Flags: review?(padamczyk) → review+
Thanks Patryk for review, patch landed on master
https://github.com/mozilla-b2g/gaia/commit/6824d2c6d1100d3f953d16dab96caaf008edfc9e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S4 (20june)
Target Milestone: 2.0 S4 (20june) → 2.0 S3 (6june)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: