Closed Bug 1015494 Opened 11 years ago Closed 11 years ago

Intermittent browser_988072_sidebar_events.js | Should have seen the right number of command,onclick events - Got 0, expected 1

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 32
Tracking Flags:
Tracking Status
firefox30 --- unaffected
firefox31 --- unaffected
firefox32 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: KWierso, Assigned: Gijs)

References

Details

(Keywords: intermittent-failure, Whiteboard: p=2 s=it-32c-31a-30b.3 [qa-])

Attachments

(2 files, 1 obsolete file)

fix sidebar state at the end of the test,
1.95 KB, patch
mconley
: review+
Gijs
: checkin+
Details | Diff | Splinter Review
allow disabling panel animations during tests,
5.70 KB, patch
mconley
: review+
Gijs
: checkin+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=40288830&tree=Fx-Team WINNT 6.2 fx-team debug test mochitest-browser-chrome-1 on 2014-05-23 10:22:18 PDT for push 459040b37060 slave: t-w864-ix-107 10:42:32 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Should have the same image attribute 10:42:32 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Should have the same checked attribute 10:42:32 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Should have the right element at the top 10:42:32 INFO - [Parent 3888] WARNING: ENSURE_TRUE(weakFrame.IsAlive()) failed: file c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\build\layout\xul\nsXULPopupManager.cpp, line 1031 10:42:32 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Should have seen the right number of click events 10:42:32 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Should have seen the right number of command events - Got 0, expected 1 10:42:32 INFO - Stack trace: 10:42:32 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 752 10:42:32 INFO - JS frame :: chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js :: checkExpectedEvents :: line 27 10:42:32 INFO - JS frame :: chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js :: <TOP_LEVEL> :: line 276 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 282 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl :: line 247 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: createAsyncFunction/asyncFunction :: line 224 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: Task_spawn :: line 139 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_handleResultValue :: line 326 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 290 10:42:32 INFO - JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Handler.prototype.process :: line 863 10:42:32 INFO - JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.walkerLoop :: line 742 10:42:32 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 10:42:32 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Should have seen the right number of onclick events - Got 0, expected 1 10:42:32 INFO - Stack trace: 10:42:32 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 752 10:42:32 INFO - JS frame :: chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js :: checkExpectedEvents :: line 27 10:42:32 INFO - JS frame :: chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js :: <TOP_LEVEL> :: line 276 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 282 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl :: line 247 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: createAsyncFunction/asyncFunction :: line 224 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: Task_spawn :: line 139 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_handleResultValue :: line 326 10:42:32 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 290 10:42:32 INFO - JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Handler.prototype.process :: line 863 10:42:32 INFO - JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.walkerLoop :: line 742 10:42:32 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 10:42:32 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Should have seen the right number of oncommand events 10:42:32 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Leaving test 10:42:32 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Entering test 10:42:32 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Check that a sidebar with a click listener and a broadcaster with an onclick attribute only sees one event :( 10:42:32 INFO - console.error: 10:42:32 INFO - [CustomizableUI] 10:42:32 INFO - Could not find a keyboard shortcut for '<menuitem xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="testsidebar" label="Test Sidebar" observes="testbroadcaster" onclick="sawEvent(event, true)"/>'. 10:42:32 INFO - ++DOMWINDOW == 101 (31E8BC98) [pid = 3888] [serial = 4488] [outer = 169C0748] 10:42:32 INFO - [Parent 3888] WARNING: Unable to create a transaction for async execution.: file c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\build\storage\src\mozStorageAsyncStatementExecution.cpp, line 596 10:42:32 INFO - [Parent 3888] WARNING: Unable to create a transaction for async execution.: file c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\build\storage\src\mozStorageAsyncStatementExecution.cpp, line 596 10:42:32 INFO - [Parent 3888] WARNING: Unable to create a transaction for async execution.: file c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\build\storage\src\mozStorageAsyncStatementExecution.cpp, line 596 10:42:32 INFO - [Parent 3888] WARNING: Unable to create a transaction for async execution.: file c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\build\storage\src\mozStorageAsyncStatementExecution.cpp, line 596 10:42:32 INFO - [Parent 3888] WARNING: Unable to create a transaction for async execution.: file c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\build\storage\src\mozStorageAsyncStatementExecution.cpp, line 596 10:42:32 INFO - [Parent 3888] WARNING: Unable to create a transaction for async execution.: file c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\build\storage\src\mozStorageAsyncStatementExecution.cpp, line 596 10:42:32 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Should have the same number of children 10:42:32 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Should have the same label attribute 10:42:32 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_988072_sidebar_events.js | Should have the same key attribute
Blocks: 988072
This doesn't fix the test (still not sure what causes the failure...) but it will make sure we don't then break other tests...
Attachment #8428821 - Flags: review?(mconley)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Are you certain these are the only tests that need this directive? Would it also not be a good idea to have a cleanup function in here so we can at least restrict any failures to this and only this file?
Flags: needinfo?(gijskruitbosch+bugs)
These are all the tests that need it, yes, but a cleanup function is a good idea. I'll do up a new version of the patch.
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8428877 - Flags: review?(mconley)
Attachment #8428821 - Attachment is obsolete: true
Attachment #8428821 - Flags: review?(mconley)
Attachment #8428877 - Flags: review?(mconley) → review+
Keywords: leave-open
Comment on attachment 8428877 [details] [diff] [review] fix sidebar state at the end of the test, https://hg.mozilla.org/integration/fx-team/rev/9241c829d819
Attachment #8428877 - Flags: checkin+
So I suspect that because of the animation we're just clicking into the void or clicking a different item, which would explain the variety of failure modes here. I'll try and look into it more tomorrow.
I'm hopeful this will help. I tried other methods of triggering a click event, but they don't trigger a command event...
Attachment #8429217 - Flags: review?(mconley)
Comment on attachment 8429217 [details] [diff] [review] allow disabling panel animations during tests, Review of attachment 8429217 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/customizableui/content/panelUI.js @@ +365,5 @@ > tempPanel.openPopup(iconAnchor || aAnchor, "bottomcenter topright"); > } > }, > > + disableAnimations: function() { We should add some documentation on what animations this is actually disabling. I can see people getting excited about being able to programmatically disable all panel animations, and we should either rename this or make it clear that this only disables animations on the tempPanel, and is used primarily for testing.
Attachment #8429217 - Flags: review?(mconley) → review+
Renamed the methods and added a doc comment above it. remote: https://hg.mozilla.org/integration/fx-team/rev/8aae60234f3b
(In reply to TBPL Robot from comment #35) This one was literally /just/ before the fix hit inbound... *crosses fingers*
Attachment #8429217 - Flags: checkin+
Per previous rate of failure, I'm going to say this is fixed on central.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Marco, looks like this needs adding to this sprint, too... :-\
Flags: needinfo?(mmucci)
Whiteboard: p=2 [qa-]
Flags: firefox-backlog+
status-firefox30: --- → unaffected
status-firefox31: --- → unaffected
status-firefox32: --- → fixed
status-firefox-esr24: --- → unaffected
Target Milestone: --- → Firefox 32
Added to Iteration 32.3
Status: RESOLVED → VERIFIED
Flags: needinfo?(mmucci)
Whiteboard: p=2 [qa-] → p=2 s=it-32c-31a-30b.3 [qa-]
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: