Closed
Bug 1015513
Opened 10 years ago
Closed 10 years ago
An app shouldn't be able to pick itself when launching an activity
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(tracking-b2g:backlog, b2g-v2.0 fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)
People
(Reporter: squib, Assigned: squib)
References
Details
(Whiteboard: interaction-design, [systemsfe] [LibGLA,Dev, B])
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
djf
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details | Review |
I noticed this while working on bug 960329. If an app can initiate, say, a share activity, and can also receive a share activity of the same type, the app is shown in the app picker when starting the activity. This doesn't really make sense, since an app shouldn't need to share with itself. I think we should detect this case and remove the calling app from the app picker when launching an activity.
Updated•10 years ago
|
Whiteboard: interaction-design
Assignee | ||
Comment 1•10 years ago
|
||
This would be really nice for the ringtones app.
blocking-b2g: --- → 2.0?
Comment 2•10 years ago
|
||
Lets fix it in 2.1
blocking-b2g: 2.0? → backlog
feature-b2g: --- → 2.1
Whiteboard: interaction-design → interaction-design, [systemsfe]
Assignee | ||
Comment 3•10 years ago
|
||
Here's a short-term workaround for the ringtones app so that we can fix this in the 2.0 timeframe.
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Attachment #8440036 -
Flags: review?(dflanagan)
Comment 4•10 years ago
|
||
Comment on attachment 8440036 [details] [review] Workaround for ringtones I left a couple of suggestions on github but I'm okay with landing this workaround as it is.
Attachment #8440036 -
Flags: review?(dflanagan) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/846f5612191b9c7956ecd83cc825f1506dc3646c
Keywords: leave-open
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8440036 [details] [review] Workaround for ringtones NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 960329 [User impact] if declined: Users can share ringtones with the ringtones app, creating unnecessary duplicates [Testing completed]: Marionette tests included in patch [Risk to taking this patch] (and alternatives if risky): Low-risk [String changes made]: None
Attachment #8440036 -
Flags: approval-gaia-v2.0?
Updated•10 years ago
|
Attachment #8440036 -
Flags: approval-gaia-v2.0? → approval-gaia-v2.0+
Assignee | ||
Updated•10 years ago
|
Assignee: squibblyflabbetydoo → nobody
Status: ASSIGNED → NEW
Assignee | ||
Comment 8•10 years ago
|
||
Because this isn't fixed yet. I only landed a workaround for the ringtone app.
Flags: needinfo?(squibblyflabbetydoo)
Comment 9•10 years ago
|
||
(In reply to Jim Porter (:squib) from comment #5) > Landed: > https://github.com/mozilla-b2g/gaia/commit/ > 846f5612191b9c7956ecd83cc825f1506dc3646c Uplifted to fix bug 1026276. v2.0: https://github.com/mozilla-b2g/gaia/commit/7260d58fb2b4665ebe614f94d822b8407bd95f58
Whiteboard: interaction-design, [systemsfe] → interaction-design, [systemsfe] [LibGLA,Dev, B]
Updated•10 years ago
|
Target Milestone: --- → 2.1 S3 (29aug)
Updated•10 years ago
|
feature-b2g: 2.1 → ---
Updated•10 years ago
|
Assignee: nobody → squibblyflabbetydoo
Comment 10•10 years ago
|
||
Should we close this one and file a new one for the real fix? It's confusing to have bugs around with patches that are already landed a while ago.
Assignee | ||
Comment 11•10 years ago
|
||
(In reply to Gregor Wagner [:gwagner] from comment #10) > Should we close this one and file a new one for the real fix? It's confusing > to have bugs around with patches that are already landed a while ago. That's fine with me.
Updated•10 years ago
|
Updated•10 years ago
|
Updated•9 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•