1015562 - "Assertion failure: !prevChildWasAnonGridItem (two anon grid items in a row)"

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

With:
  user_pref("layout.css.grid.enabled", true);

Assertion failure: !prevChildWasAnonGridItem (two anon grid items in a row), at layout/generic/nsGridContainerFrame.cpp:131

An assertion added in bug 1009272 caught something!

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix+test

I completely missed one of the nsGkAtoms::flexContainerFrame checks
that should also check for grid containers.  I'm adding a convenience
function for this so an individual flex/gridContainerFrame check will
stand out more to help avoid this.  I checked the remaining uses
(in this file) and it looks OK now.

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8428332 [details] [diff] [review]
fix+test

>+++ b/layout/generic/crashtests/crashtests.list
>@@ -526,8 +526,9 @@ load 943509-1.html
> asserts(3-6) load 944909-1.html
> test-pref(layout.css.sticky.enabled,true) load 949932.html
> load 973701-1.xhtml
> load 973701-2.xhtml
> load 986899.html
> load 1001233.html
> load 1001258-1.html
> load outline-on-frameset.xhtml
>+pref(layout.css.grid.enabled,true) load 1015562.html

nit: probably insert this one line higher, to keep things alphabetically-sorted. (& keep numbers grouped together)

r=me

Comment 4

[Mats Palmgren (inactive)]

With the nit fixed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea97b234c940

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/ea97b234c940