Closed Bug 1015602 Opened 6 years ago Closed 6 years ago

division by zero crash or bin-unused and heap-chunks too huge (jemalloc3)

Categories

(Core :: Memory Allocator, defect)

All
FreeBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file)

Attached patch workaroundSplinter Review
Bug 1006769 Part 1 added memory reporters for |chunksize| and |bin_unused| (new) fields of jemalloc_stats_t. Calculating the former is trivial but the latter may need upstream help or poking with dalloc bins stats.

Explicit Allocations

32,885.73 MB (100.0%) -- explicit
├──32,803.28 MB (99.75%) -- heap-overhead
│  ├──32,801.46 MB (99.74%) ── bin-unused
│  └───────1.82 MB (00.01%) ++ (3 tiny)
└──────82.45 MB (00.25%) ++ (22 tiny)

Other Measurements 

 57.72 MB ── heap-allocated
3,366,480 ── heap-chunks
  0.00 MB ── heap-chunksize
 59.54 MB ── heap-committed
 61.00 MB ── heap-mapped
    3.15% ── heap-overhead-ratio
Comment on attachment 8428252 [details] [diff] [review]
workaround

Review of attachment 8428252 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #8428252 - Flags: review+
I've wanted to update the comment but there's probably not much point. Except for file/function_name it already carries enough information. Adding a wrong hint is worse.

  // We could get this value out of base.c::base_pages, but that really should
  // be an upstream change, so don't worry about it for now.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/57dd204266ba
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Do we need land it on v1.3t? It blocks bug 1006769.
Flags: needinfo?(fabrice)
blocking-b2g: --- → 1.3T?
1.3T already fixed. marking 1.3T+
blocking-b2g: 1.3T? → 1.3T+
You need to log in before you can comment on or make changes to this bug.