1015665 - Add recording options to CallWatcherActor

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

When exposing ChromeOnly properties on objects obtained by call-watcher actor, I'm unable to get these ChromeOnly properties, as by the time they get to the webaudio actor, they've already been wrapped. I think call-watcher should work with XPCWrapper objects and expose those to the consuming actors (webgl, webaudio, canvas(?)), where they can be unwrapped if they need to be.

I think this is necessary, and should be a relatively easy patch to add this and change the consuming actors to handle it, but wanted to run it by you Victor, and see if there are any downsides you can see.

Comment 1

[Victor Porof [:vporof][:vp]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #0)

Why not wrap the referenced objects again? You'll get the same object.

let unwrapped = XPCNativeWrapper.unwrap(content);
let wrapped = new XPCNativeWrapper(unwrapped);
wrapped == content // true

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Thought of doing that, but thought that it may be better to just expose the wrappers from call-watcher itself, rather than doing extra work to ensure that we're securely accessing the correct properties. Either way, you're right, I can just rewrap the object, but maybe this is something we can do in the future to lean up our code.

Comment 3

[Victor Porof [:vporof][:vp]]

I honestly don't mind either way. Let's fix this bug if you think it's more elegant or efficient!

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

This may be more work than what I want to do right now, but ultimately probably the best solution. Running into situations where objects, depending on how they're obtained (return value, property of an object, shallow vs deep) it can differ, so there's a lot of flipping of wrap/unwrap in the webaudio actor that doesn't really make sense (maybe if one is intimately familiar with all the XPCNativeWrapper rules, but have read over that several times and it leaves me with ugly code). 

Gonna leave this open as a nice refactoring for the future, but won't hold up on the GC work for audio nodes.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Add options to CWA specifying whether or not the FunctionCalls should be saved in an array, as well as if it's dealing with wrapped, or unwrapped, objects.

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Adding this to bug 1022248, since I think it'll help with some perf issues the web audio editor's seeing

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1015665-dont-store-calls-callwatcheractor.patch

What're your thoughts on something like this? Only store all function calls in the appropriate tools

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

https://tbpl.mozilla.org/?tree=Try&rev=cc4681dddafc

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/2307dffdebfe

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2307dffdebfe