1015754 - Cleanup mouse events

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Tom S [:evilpie]]

Attachment: mouse

This unifies some code and adds support for back/forward buttons.

Comment 1

[Oleg Romashin (:romaxa)]

Comment on attachment 8428394 [details] [diff] [review]
mouse

>+static void
>+InitMouseEvent(WidgetMouseEvent& aMouseEvent, QMouseEvent* aEvent,
>+               int aClickCount)
>+{
>+    aMouseEvent.refPoint.x = nscoord(aEvent->pos().x());
>+    aMouseEvent.refPoint.y = nscoord(aEvent->pos().y());
>+
>+    aMouseEvent.InitBasicModifiers(aEvent->modifiers() & Qt::ControlModifier,
>+                                  aEvent->modifiers() & Qt::AltModifier,

nit:                               ^ - indent it

Comment 2

[Tom S [:evilpie]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9366dce4c861

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9366dce4c861