Closed Bug 1015754 Opened 6 years ago Closed 6 years ago

Cleanup mouse events

Categories

(Core Graveyard :: Widget: Qt, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: evilpie, Assigned: evilpie)

Details

Attachments

(1 file)

Attached patch mouseSplinter Review
This unifies some code and adds support for back/forward buttons.
Attachment #8428394 - Flags: review?(romaxa)
Comment on attachment 8428394 [details] [diff] [review]
mouse

>+static void
>+InitMouseEvent(WidgetMouseEvent& aMouseEvent, QMouseEvent* aEvent,
>+               int aClickCount)
>+{
>+    aMouseEvent.refPoint.x = nscoord(aEvent->pos().x());
>+    aMouseEvent.refPoint.y = nscoord(aEvent->pos().y());
>+
>+    aMouseEvent.InitBasicModifiers(aEvent->modifiers() & Qt::ControlModifier,
>+                                  aEvent->modifiers() & Qt::AltModifier,

nit:                               ^ - indent it
Attachment #8428394 - Flags: review?(romaxa) → review+
Assignee: nobody → evilpies
https://hg.mozilla.org/mozilla-central/rev/9366dce4c861
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.