1015796 - Followup of bug 1015090: Revise BluetoothAttributeEvent.webidl with attribute |attrs| as type sequence<DOMString>

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

Attribute |value| in BluetoothAttributeEvent.webidl should be revised to union type once IDL supports sequence in union type (bug 767921).

Comment 1

[Ben Tian (inactive)]

Correct bug number to depend: 767924

Attribute |value| in BluetoothAttributeEvent.webidl should be revised to union type once IDL supports sequence in union type (bug 767924).

Comment 2

[Ben Tian (inactive)]

try: https://tbpl.mozilla.org/?tree=Try&rev=415e0c583b4d

Comment 3

[Ben Tian (inactive)]

Change bug title as we revise API design in bug 1019544 comment 30.

We have to make attribute |attrs| of type sequence<DOMString> once sequence is supported in event codegen (bug 1023762).

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1015796: Use sequence<DOMString> as the type of attribute |attrs| in BluetoothAttributeEvent instead of any.

Hi Ben,

Could you help to review my patch?

Thanks,
Jocelyn

Comment 5

[Ben Tian (inactive)]

Comment on attachment 8593736 [details] [diff] [review]
Bug 1015796: Use sequence<DOMString> as the type of attribute |attrs| in BluetoothAttributeEvent instead of any.

Review of attachment 8593736 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Please request a DOM peer review for webidl change.

Comment 6

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8593736 [details] [diff] [review]
Bug 1015796: Use sequence<DOMString> as the type of attribute |attrs| in BluetoothAttributeEvent instead of any.

Hi Blake,

Could you help to review this webidl and related implementation change?

Thanks,
Jocelyn

Comment 7

[Jocelyn Liu [:jocelyn] [:joliu]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b063fab8d30

Comment 8

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1015796: Use sequence<DOMString> as the type of attribute |attrs| in BluetoothAttributeEvent instead of any. r=btian, r=mrbkap

Thanks for your time, Ben and Blake.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d04f55be10fb

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d04f55be10fb