Closed Bug 1015796 Opened 6 years ago Closed 6 years ago

Followup of bug 1015090: Revise BluetoothAttributeEvent.webidl with attribute |attrs| as type sequence<DOMString>

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
2.2 S11 (1may)
Tracking Status
firefox40 --- fixed

People

(Reporter: ben.tian, Assigned: yrliou)

References

Details

(Whiteboard: [webbt-api])

Attachments

(1 file, 1 obsolete file)

Attribute |value| in BluetoothAttributeEvent.webidl should be revised to union type once IDL supports sequence in union type (bug 767921).
Correct bug number to depend: 767924

Attribute |value| in BluetoothAttributeEvent.webidl should be revised to union type once IDL supports sequence in union type (bug 767924).
Depends on: 767924
Whiteboard: [webbt-api]
Change bug title as we revise API design in bug 1019544 comment 30.

We have to make attribute |attrs| of type sequence<DOMString> once sequence is supported in event codegen (bug 1023762).
Depends on: 1023762
No longer depends on: 767924
Summary: Followup of bug 1015090: Revise BluetoothAttributeEvent.webidl with attribute |value| as union type → Followup of bug 1015090: Revise BluetoothAttributeEvent.webidl with attribute |attrs| as type sequence<DOMString>
Depends on: 767924
Assignee: nobody → joliu
Hi Ben,

Could you help to review my patch?

Thanks,
Jocelyn
Attachment #8593736 - Flags: review?(btian)
Comment on attachment 8593736 [details] [diff] [review]
Bug 1015796: Use sequence<DOMString> as the type of attribute |attrs| in BluetoothAttributeEvent instead of any.

Review of attachment 8593736 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Please request a DOM peer review for webidl change.
Attachment #8593736 - Flags: review?(btian) → review+
Comment on attachment 8593736 [details] [diff] [review]
Bug 1015796: Use sequence<DOMString> as the type of attribute |attrs| in BluetoothAttributeEvent instead of any.

Hi Blake,

Could you help to review this webidl and related implementation change?

Thanks,
Jocelyn
Attachment #8593736 - Flags: review?(mrbkap)
Attachment #8593736 - Flags: review?(mrbkap) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d04f55be10fb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in before you can comment on or make changes to this bug.