Closed
Bug 1015796
Opened 11 years ago
Closed 10 years ago
Followup of bug 1015090: Revise BluetoothAttributeEvent.webidl with attribute |attrs| as type sequence<DOMString>
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ben.tian, Assigned: yrliou)
References
Details
(Whiteboard: [webbt-api])
Attachments
(1 file, 1 obsolete file)
Attribute |value| in BluetoothAttributeEvent.webidl should be revised to union type once IDL supports sequence in union type (bug 767921).
Reporter | ||
Comment 1•11 years ago
|
||
Correct bug number to depend: 767924
Attribute |value| in BluetoothAttributeEvent.webidl should be revised to union type once IDL supports sequence in union type (bug 767924).
Depends on: 767924
Whiteboard: [webbt-api]
Reporter | ||
Comment 2•11 years ago
|
||
Reporter | ||
Comment 3•11 years ago
|
||
Change bug title as we revise API design in bug 1019544 comment 30.
We have to make attribute |attrs| of type sequence<DOMString> once sequence is supported in event codegen (bug 1023762).
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → joliu
Assignee | ||
Comment 4•10 years ago
|
||
Hi Ben,
Could you help to review my patch?
Thanks,
Jocelyn
Attachment #8593736 -
Flags: review?(btian)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8593736 [details] [diff] [review]
Bug 1015796: Use sequence<DOMString> as the type of attribute |attrs| in BluetoothAttributeEvent instead of any.
Review of attachment 8593736 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. Please request a DOM peer review for webidl change.
Attachment #8593736 -
Flags: review?(btian) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8593736 [details] [diff] [review]
Bug 1015796: Use sequence<DOMString> as the type of attribute |attrs| in BluetoothAttributeEvent instead of any.
Hi Blake,
Could you help to review this webidl and related implementation change?
Thanks,
Jocelyn
Attachment #8593736 -
Flags: review?(mrbkap)
Updated•10 years ago
|
Attachment #8593736 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Thanks for your time, Ben and Blake.
Attachment #8593736 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Keywords: checkin-needed
Comment 10•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in
before you can comment on or make changes to this bug.
Description
•