1015821 - [Tarako] Incorrect roaming status.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[shawn ku [:sku]]

Attachment: main.log

SIM IMSI: 404971038529451
Device camp on 404-10

There is no 404-10 in EF_SPDI. And EF_SPN is with alphatag : airtel, display condition 0.


RadioInterface will revert roaming status after function checkRoamingBetweenOperators (see [1]) which is claim as wrong behavior from partner.



[1] - http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js?from=RadioInterfaceLayer.js&case=true#2373

01-23 06:52:09.470    85   323 I Gecko   : RIL Worker: [0] SPDI: SPDI service is not available
01-23 06:52:10.900    85   323 I Gecko   : RIL Worker: [0] SPN: spn = airtel, spnDisplayCondition = 0
...
05-15 11:07:55.532    96   346 D RILC    : [0088]< VOICE_REGISTRATION_STATE {5,eb,8bd0,2,(null),(null),(null),0,(null),(null),(null),(null),(null),(null),(null)}
05-15 11:07:55.672    96   346 D RILC    : [0097]< OPERATOR {AirTel,AirTel,40410}


05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: longName =airtel
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: shortName =airtel
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: equalsLongName =true
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: equalsShortName =true
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: equalsMcc =true
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: registration.roaming =false
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: longName =airtel
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: shortName =airtel
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: equalsLongName =true
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: equalsShortName =true
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: equalsMcc =true
05-15 11:07:55.792    85    85 I Gecko   : -*- RadioInterface[0]: checkRoamingBetweenOperators: registration.roaming =false

Comment 1

[shawn ku [:sku]]

Attachment: radio.log

Comment 2

[shawn ku [:sku]]

AOSP (4.2) did similar check, but no any case conversion for long/short name.
That's why reference phone did not have such symptom.

https://code.google.com/p/android-source-browsing/source/browse/telephony/java/com/android/internal/telephony/gsm/GsmServiceStateTracker.java?repo=platform--frameworks--base&name=ics-plus-aosp&r=429dad687bcb5f00587e8b91b3a614502907aaa1#1205

Comment 3

[shawn ku [:sku]]

Hi Alexandre:
 Could you please help recall the memory of [1]?

1. Check if we still hit issue on newer device w/o checkRoamingBetweenOperators?
2. AOSP did the same check, but w/o any case conversion, can I know why we need "operator.longName.toLowerCase();" and "operator.shortName.toLowerCase()" in the function? 


[1] - http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js?from=RadioInterfaceLayer.js&case=true#2367

Comment 4

[:gerard-majax]

(In reply to shawn ku [:sku] from comment #3)
> Hi Alexandre:
>  Could you please help recall the memory of [1]?
> 
> 1. Check if we still hit issue on newer device w/o
> checkRoamingBetweenOperators?
> 2. AOSP did the same check, but w/o any case conversion, can I know why we
> need "operator.longName.toLowerCase();" and
> "operator.shortName.toLowerCase()" in the function? 
> 
> 
> [1] -
> http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/
> RadioInterfaceLayer.js?from=RadioInterfaceLayer.js&case=true#2367

My original patch did not include any case handling. This change has been done in http://hg.mozilla.org/mozilla-central/diff/1602ef5c86e2/dom/system/gonk/RadioInterfaceLayer.js for bug 797972.

Comment 5

[shawn ku [:sku]]

(In reply to Alexandre LISSY :gerard-majax from comment #4)
> (In reply to shawn ku [:sku] from comment #3)
> > Hi Alexandre:
> >  Could you please help recall the memory of [1]?
> > 
> > 1. Check if we still hit issue on newer device w/o
> > checkRoamingBetweenOperators?
> > 2. AOSP did the same check, but w/o any case conversion, can I know why we
> > need "operator.longName.toLowerCase();" and
> > "operator.shortName.toLowerCase()" in the function? 
> > 
> > 
> > [1] -
> > http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/
> > RadioInterfaceLayer.js?from=RadioInterfaceLayer.js&case=true#2367
> 
> My original patch did not include any case handling. This change has been
> done in
> http://hg.mozilla.org/mozilla-central/diff/1602ef5c86e2/dom/system/gonk/
> RadioInterfaceLayer.js for bug 797972.

Thanks!! Alexandre.

Comment 6

[sam.hua]

Hi shawn,
so the issue could be fixed if we don't use toLowerCase ?

Comment 7

[shawn ku [:sku]]

Attachment: [unofficial WIP] Patch

Comment 8

[shawn ku [:sku]]

Hi Sam:
 Could you please apply the patch to tarako, and request a trial in India?
(Moz will work on m-c/1.4 patch)

Thanks!!
Shawn Ku

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

hi Shawn, since you are working on this do you mind taking? thanks

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

ni? James Zhang
it seems like this bug is closed on your bug system. can you please confirm? is this still needed for tarako? thanks

Comment 11

[shawn ku [:sku]]

Hi Joe:
 I can surely take this bug, however, two test cases will be impacted on m-c trunk.

gecko/dom/mobileconnection/tests/marionette/test_mobile_operator_names_roaming.js
gecko/dom/mobileconnection/tests/marionette/test_mobile_data_state.js

if partner needs patch urgently, they can pick from "[unofficial WIP] Patch".

Thanks!!
Shawn

Comment 12

[Ken Chang[:kenkai]]

(In reply to shawn ku [:sku] from comment #11)
> 
> if partner needs patch urgently, they can pick from "[unofficial WIP] Patch".
Let's see what is James' response. If this is the conclusion, let's use this bug to land this short term solution. I will file another bug for long term solution. Thanks.

Comment 13

[James Zhang (Spreadtrum)]

(In reply to Joe Cheng [:jcheng] from comment #10)
> ni? James Zhang
> it seems like this bug is closed on your bug system. can you please confirm?
> is this still needed for tarako? thanks

We land WIP patch on our side to close bug.
But I think you'd better land it on v1.3t.

Comment 14

[sam.hua]

yes, it passed the test in India,

please merge it into v1.3t and V1.4.

Thanks!

Comment 15

[Joe Cheng [:jcheng] (please needinfo)]

1.3T+, hi Shawn, let's land this on 1.3T. thanks

Comment 16

[sam.hua]

we need it fixed in v1.4 too.

Comment 17

[Ken Chang[:kenkai]]

(In reply to Joe Cheng [:jcheng] from comment #15)
> 1.3T+, hi Shawn, let's land this on 1.3T. thanks
Does SPRD friends own a full control for 1.3T? 
Because this is a short term solution, we don't want to spend a lot of time in this. We will try to find a long term solution for this. But the long term solution won't be provided in few weeks.

Comment 18

[Joe Cheng [:jcheng] (please needinfo)]

yes, do you mean our partner can just land the short term solution provided and close this bug?
can we still do a review of the patch? Thanks

Comment 19

[Ken Chang[:kenkai]]

(In reply to Joe Cheng [:jcheng] from comment #18)
> can we still do a review of the patch? Thanks
Sure.
Shawn, would you please upload an official patch for this bug? Edgar can help to review it.

Comment 20

[shawn ku [:sku]]

I will provide 1.3t patch by 6/5.
For 1.4/m-c, we still need more discuss due to comment 11.

Comment 21

[shawn ku [:sku]]

Attachment: [1.3t] Bug 1015821 - [Tarako] Incorrect roaming status.

Comment 22

[Edgar Chen [:edgar]]

Comment on attachment 8434727 [details] [diff] [review]
[1.3t] Bug 1015821 - [Tarako] Incorrect roaming status.

Review of attachment 8434727 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you.

Comment 23

[shawn ku [:sku]]

try is green - https://tbpl.mozilla.org/?tree=Try&rev=14bc5c75c237

Comment 24

[Edgar Chen [:edgar]]

This patch will only be landed into 1.3T.

Comment 25

[sam.hua]

but v1.4 also need it

Comment 26

[shawn ku [:sku]]

Attachment: [1.3t] Bug 1015821 - [Tarako] Incorrect roaming status. r=echen. a=1.3t+.

Comment 27

[shawn ku [:sku]]

(In reply to sam.hua from comment #25)
> but v1.4 also need it

Sam, 1.4 and m-c will be tracked on Bug 1020824.

Comment 28

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/445677582548